[PR #1143] [MERGED] Format some common Lettre errors a bit simpler #3509

New Issue

OVERLORD · 2025-10-09T18:24:40+03:00

OVERLORD commented

2025-10-09 18:24:40 +03:00

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/1143
Author: @BlackDex
Created: 9/14/2020
Status: ✅ Merged
Merged: 9/14/2020
Merged by: @dani-garcia

Base: master ← Head: better-lettre-errors

📝 Commits (1)

6a0d024 Format some common Lettre errors a bit simpler

📊 Changes

2 files changed (+22 additions, -4 deletions)

View changed files

📝 src/error.rs (+1 -1)
📝 src/mail.rs (+21 -3)

📄 Description

Currently when for example using the admin interface to send out a test e-mail just
returns SmtpError. This is not very helpful. What i have done.

Match some common Lettre errors to return the error message.
Other errors will just be passed on as before.

Some small other changes:

Fixed a clippy warning about using clone().
Fixed a typo where Lettere was spelled with one t.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/1143 **Author:** [@BlackDex](https://github.com/BlackDex) **Created:** 9/14/2020 **Status:** ✅ Merged **Merged:** 9/14/2020 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `master` ← **Head:** `better-lettre-errors` --- ### 📝 Commits (1) - [`6a0d024`](https://github.com/dani-garcia/vaultwarden/commit/6a0d024c69dc6c0a060191085f66c5dc25f1426e) Format some common Lettre errors a bit simpler ### 📊 Changes **2 files changed** (+22 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/error.rs` (+1 -1) 📝 `src/mail.rs` (+21 -3) </details> ### 📄 Description Currently when for example using the admin interface to send out a test e-mail just returns `SmtpError`. This is not very helpful. What i have done. - Match some common Lettre errors to return the error message. - Other errors will just be passed on as before. Some small other changes: - Fixed a clippy warning about using clone(). - Fixed a typo where Lettere was spelled with one t. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2025-10-09 18:24:41 +03:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/vaultwarden#3509