[PR #1499] [CLOSED] Use minified scripts #3420

New Issue

Closed

opened 2025-10-09 18:23:02 +03:00 by OVERLORD · 0 comments

OVERLORD commented 2025-10-09 18:23:02 +03:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/1499
Author: @RealOrangeOne
Created: 3/16/2021
Status: ❌ Closed

Base: master ← Head: use-minified-scripts

---

📝 Commits (5)

• 5ca580b Use minified version of jquery-slim
• c1a8e79 Use minified version of datatables.js
• 8074cc8 Use minified version of datatables.css
• 30951c2 Use minified version of bootstrap.css
• 7dc9f33 Use minified version of bootstrap-native

📊 Changes

14 files changed (+253 additions, -36533 deletions)

View changed files

📝 src/api/web.rs (+5 -5)
➖ src/static/scripts/bootstrap-native.js (+0 -1673)
➕ src/static/scripts/bootstrap-native.min.js (+2 -0)
➖ src/static/scripts/bootstrap.css (+0 -10263)
➕ src/static/scripts/bootstrap.min.css (+7 -0)
➖ src/static/scripts/datatables.css (+0 -224)
➖ src/static/scripts/datatables.js (+0 -15583)
➕ src/static/scripts/datatables.min.css (+15 -0)
➕ src/static/scripts/datatables.min.js (+214 -0)
➖ src/static/scripts/jquery-3.5.1.slim.js (+0 -8777)
➕ src/static/scripts/jquery-3.5.1.slim.min.js (+2 -0)
📝 src/static/templates/admin/base.hbs (+2 -2)
📝 src/static/templates/admin/organizations.hbs (+3 -3)
📝 src/static/templates/admin/users.hbs (+3 -3)

📄 Description

Use minified versions of CSS and JS libraries. This has a few benefits:

• Reduces the size of the resulting binary, and thus docker container
• Reduces page load size
• Reduces the chance of a new contributor trying to edit part of the library themselves directly (albeit a small chance)
• Reduce the amount of JS in the repository (GitHub ignores minified files, so should show this repository as being mostly rust!)

I've not changed the version of any file, and each commit contains where it was downloaded from, should someone want to verify it's not been modified. I couldn't find a minified version of identicons, so left as-is.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/1499 **Author:** [@RealOrangeOne](https://github.com/RealOrangeOne) **Created:** 3/16/2021 **Status:** ❌ Closed **Base:** `master` ← **Head:** `use-minified-scripts` --- ### 📝 Commits (5) - [`5ca580b`](https://github.com/dani-garcia/vaultwarden/commit/5ca580b83e69c176560ed7bd9d8d73e60bf8b00d) Use minified version of jquery-slim - [`c1a8e79`](https://github.com/dani-garcia/vaultwarden/commit/c1a8e7923e49ca16b7b6a6d21fe430b764f4b65a) Use minified version of datatables.js - [`8074cc8`](https://github.com/dani-garcia/vaultwarden/commit/8074cc8b42d1f23af8ca49bcaa143c81467bf53b) Use minified version of datatables.css - [`30951c2`](https://github.com/dani-garcia/vaultwarden/commit/30951c2cf39674271bd0d69df05d3cfb84a3db84) Use minified version of bootstrap.css - [`7dc9f33`](https://github.com/dani-garcia/vaultwarden/commit/7dc9f334bdb498587351e6afb62b227f2754a8a7) Use minified version of bootstrap-native ### 📊 Changes **14 files changed** (+253 additions, -36533 deletions) <details> <summary>View changed files</summary> 📝 `src/api/web.rs` (+5 -5) ➖ `src/static/scripts/bootstrap-native.js` (+0 -1673) ➕ `src/static/scripts/bootstrap-native.min.js` (+2 -0) ➖ `src/static/scripts/bootstrap.css` (+0 -10263) ➕ `src/static/scripts/bootstrap.min.css` (+7 -0) ➖ `src/static/scripts/datatables.css` (+0 -224) ➖ `src/static/scripts/datatables.js` (+0 -15583) ➕ `src/static/scripts/datatables.min.css` (+15 -0) ➕ `src/static/scripts/datatables.min.js` (+214 -0) ➖ `src/static/scripts/jquery-3.5.1.slim.js` (+0 -8777) ➕ `src/static/scripts/jquery-3.5.1.slim.min.js` (+2 -0) 📝 `src/static/templates/admin/base.hbs` (+2 -2) 📝 `src/static/templates/admin/organizations.hbs` (+3 -3) 📝 `src/static/templates/admin/users.hbs` (+3 -3) </details> ### 📄 Description Use minified versions of CSS and JS libraries. This has a few benefits: - Reduces the size of the resulting binary, and thus docker container - Reduces page load size - Reduces the chance of a new contributor trying to edit part of the library themselves directly (albeit a small chance) - Reduce the amount of JS in the repository (GitHub ignores minified files, so should show this repository as being mostly rust!) I've not changed the version of any file, and each commit contains where it was downloaded from, should someone want to verify it's not been modified. I couldn't find a minified version of identicons, so left as-is. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

OVERLORD added the pull-request label 2025-10-09 18:23:03 +03:00

OVERLORD closed this issue 2025-10-09 18:23:03 +03:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

test_dylint

1.34.3

1.34.2

1.34.1

1.34.0

1.33.2

1.33.1

1.33.0

1.32.7

1.32.6

1.32.5

1.32.4

1.32.3

1.32.2

1.32.1

1.32.0

1.31.0

1.30.5

1.30.4

1.30.3

1.30.2

1.30.1

1.30.0

1.29.2

1.29.1

1.29.0

1.28.1

1.28.0

1.27.0

1.26.0

1.25.2

1.25.1

1.25.0

1.24.0

1.23.1

1.23.0

1.22.2

1.22.1

1.22.0

1.21.0

1.20.0

1.19.0

1.18.0

1.17.0

1.16.3

1.16.2

1.16.1

1.16.0

1.15.1

1.15.0

1.14.2

1.14.1

1.14

1.13.1

1.13.0

1.12.0

1.11.0

1.10.0

1.9.1

1.9.0

1.8.0

1.7.0

1.6.1

1.6.0

1.5.0

1.4.0

1.3.0

1.2.0

1.1.0

1.0.0

0.13.0

0.12.0

0.11.0

0.10.0

0.9.0

Labels

Clear labels

better for forum

bug

bug

bug

documentation

duplicate

enhancement

future Vault

good first issue

help wanted

low priority

notes

pull-request

Mirrored from GitHub Pull Request

question

SSO

Third party

troubleshooting

troubleshooting

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

OVERLORD

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/vaultwarden#3420