[PR #4448] [MERGED] Use async verify for Yubikey #3405

New Issue

OVERLORD · 2026-02-05T05:27:08+03:00

OVERLORD commented

2026-02-05 05:27:08 +03:00

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/4448
Author: @dani-garcia
Created: 3/23/2024
Status: ✅ Merged
Merged: 3/23/2024
Merged by: @dani-garcia

Base: main ← Head: yubico-async

📝 Commits (1)

f6803bf Use async verify for Yubikey

📊 Changes

1 file changed (+5 additions, -12 deletions)

View changed files

📝 src/api/core/two_factor/yubikey.rs (+5 -12)

📄 Description

While looking through the crates that we have that use reqwest 0.11, I discovered that the yubico crate can do async verification, so we can avoid the spawn_blocking. I've also changed the error handling a bit to properly log any returned errors.

I've tried it with my yubikeys and seems to work fine.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/4448 **Author:** [@dani-garcia](https://github.com/dani-garcia) **Created:** 3/23/2024 **Status:** ✅ Merged **Merged:** 3/23/2024 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `yubico-async` --- ### 📝 Commits (1) - [`f6803bf`](https://github.com/dani-garcia/vaultwarden/commit/f6803bfa3ca114291bdb845802d38c014f5722ce) Use async verify for Yubikey ### 📊 Changes **1 file changed** (+5 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `src/api/core/two_factor/yubikey.rs` (+5 -12) </details> ### 📄 Description While looking through the crates that we have that use reqwest 0.11, I discovered that the yubico crate can do async verification, so we can avoid the spawn_blocking. I've also changed the error handling a bit to properly log any returned errors. I've tried it with my yubikeys and seems to work fine. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 05:27:08 +03:00

OVERLORD closed this issue

2026-02-05 05:27:13 +03:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/vaultwarden#3405