[PR #1730] [MERGED] Add support for v2 attachment upload APIs #3373

New Issue

Open

opened 2025-10-09 18:22:14 +03:00 by OVERLORD · 0 comments

OVERLORD commented 2025-10-09 18:22:14 +03:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/1730
Author: @jjlin
Created: 5/25/2021
Status: ✅ Merged
Merged: 5/30/2021
Merged by: @dani-garcia

Base: main ← Head: attachment-upload-v2

---

📝 Commits (4)

• 29ed82a Add support for v2 attachment upload APIs
• 5fef798 Clean up attachment error handling
• c2ef331 Rework file ID generation
• 3f7e471 Fix attachment size limit calculation for v2 uploads

📊 Changes

4 files changed (+236 additions, -42 deletions)

View changed files

📝 src/api/core/ciphers.rs (+195 -26)
📝 src/api/core/sends.rs (+1 -1)
📝 src/crypto.rs (+15 -2)
📝 src/db/models/attachment.rs (+25 -13)

📄 Description

Upstream PR: https://github.com/bitwarden/server/pull/1229

The legacy upload flow can be tested with v2.19 of the web vault.

The v2 upload flow can be tested with v2.20 of the web vault.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/1730 **Author:** [@jjlin](https://github.com/jjlin) **Created:** 5/25/2021 **Status:** ✅ Merged **Merged:** 5/30/2021 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `attachment-upload-v2` --- ### 📝 Commits (4) - [`29ed82a`](https://github.com/dani-garcia/vaultwarden/commit/29ed82a3595e0cdd39deb914dc38002478f89f97) Add support for v2 attachment upload APIs - [`5fef798`](https://github.com/dani-garcia/vaultwarden/commit/5fef7983f4e3bc942ec0f029037454edfb057cad) Clean up attachment error handling - [`c2ef331`](https://github.com/dani-garcia/vaultwarden/commit/c2ef331df9d2a1a3e50ed8129b07cca0a52e6f41) Rework file ID generation - [`3f7e471`](https://github.com/dani-garcia/vaultwarden/commit/3f7e4712cd9e62ce85f58e449074b98e5c95a142) Fix attachment size limit calculation for v2 uploads ### 📊 Changes **4 files changed** (+236 additions, -42 deletions) <details> <summary>View changed files</summary> 📝 `src/api/core/ciphers.rs` (+195 -26) 📝 `src/api/core/sends.rs` (+1 -1) 📝 `src/crypto.rs` (+15 -2) 📝 `src/db/models/attachment.rs` (+25 -13) </details> ### 📄 Description Upstream PR: https://github.com/bitwarden/server/pull/1229 The legacy upload flow can be tested with v2.19 of the web vault. The v2 upload flow can be tested with v2.20 of the web vault. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

OVERLORD added the pull-request label 2025-10-09 18:22:14 +03:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

test_dylint

1.34.3

1.34.2

1.34.1

1.34.0

1.33.2

1.33.1

1.33.0

1.32.7

1.32.6

1.32.5

1.32.4

1.32.3

1.32.2

1.32.1

1.32.0

1.31.0

1.30.5

1.30.4

1.30.3

1.30.2

1.30.1

1.30.0

1.29.2

1.29.1

1.29.0

1.28.1

1.28.0

1.27.0

1.26.0

1.25.2

1.25.1

1.25.0

1.24.0

1.23.1

1.23.0

1.22.2

1.22.1

1.22.0

1.21.0

1.20.0

1.19.0

1.18.0

1.17.0

1.16.3

1.16.2

1.16.1

1.16.0

1.15.1

1.15.0

1.14.2

1.14.1

1.14

1.13.1

1.13.0

1.12.0

1.11.0

1.10.0

1.9.1

1.9.0

1.8.0

1.7.0

1.6.1

1.6.0

1.5.0

1.4.0

1.3.0

1.2.0

1.1.0

1.0.0

0.13.0

0.12.0

0.11.0

0.10.0

0.9.0

Labels

Clear labels

better for forum

bug

bug

bug

documentation

duplicate

enhancement

future Vault

good first issue

help wanted

low priority

notes

pull-request

Mirrored from GitHub Pull Request

question

SSO

Third party

troubleshooting

troubleshooting

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

OVERLORD

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/vaultwarden#3373