[PR #1966] [MERGED] Fix issue when using uppercase chars in emails #3333

Closed
opened 2025-10-09 18:21:25 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/1966
Author: @BlackDex
Created: 9/7/2021
Status: Merged
Merged: 9/9/2021
Merged by: @dani-garcia

Base: mainHead: issue-1963


📝 Commits (1)

  • 10d5c77 Fix issue when using uppercase chars in emails

📊 Changes

4 files changed (+18 additions, -15 deletions)

View changed files

📝 src/api/admin.rs (+1 -1)
📝 src/api/core/accounts.rs (+9 -8)
📝 src/api/core/organizations.rs (+4 -3)
📝 src/db/models/user.rs (+4 -3)

📄 Description

In the case when SMTP is disabled and.
when inviting new users either via the admin interface or into an
organization and using uppercase letters, this would fail for those
users to be able to register since the checks which were done are
case-sensitive and never matched.

This PR fixes that issue by ensuring everything is lowercase.
Fixes #1963


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/1966 **Author:** [@BlackDex](https://github.com/BlackDex) **Created:** 9/7/2021 **Status:** ✅ Merged **Merged:** 9/9/2021 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `issue-1963` --- ### 📝 Commits (1) - [`10d5c77`](https://github.com/dani-garcia/vaultwarden/commit/10d5c7738afad9f81958e24baa923530314a587f) Fix issue when using uppercase chars in emails ### 📊 Changes **4 files changed** (+18 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `src/api/admin.rs` (+1 -1) 📝 `src/api/core/accounts.rs` (+9 -8) 📝 `src/api/core/organizations.rs` (+4 -3) 📝 `src/db/models/user.rs` (+4 -3) </details> ### 📄 Description In the case when SMTP is disabled and. when inviting new users either via the admin interface or into an organization and using uppercase letters, this would fail for those users to be able to register since the checks which were done are case-sensitive and never matched. This PR fixes that issue by ensuring everything is lowercase. Fixes #1963 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2025-10-09 18:21:25 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/vaultwarden#3333