[PR #3803] [MERGED] enforce 2FA policy on removal of second factor and login #3310

Closed
opened 2026-02-05 05:22:48 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/3803
Author: @stefan0xC
Created: 8/27/2023
Status: Merged
Merged: 1/1/2024
Merged by: @dani-garcia

Base: mainHead: enforce-2fa-policy-on-removal


📝 Commits (3)

  • cb36ee5 enforce 2fa policy on removal of second factor
  • d5847e6 use &str instead of String in log_event()
  • 8a8b0c7 enforce the 2fa policy on login

📊 Changes

7 files changed (+163 additions, -122 deletions)

View changed files

📝 src/api/admin.rs (+8 -4)
📝 src/api/core/ciphers.rs (+8 -16)
📝 src/api/core/events.rs (+2 -2)
📝 src/api/core/organizations.rs (+35 -58)
📝 src/api/core/two_factor/mod.rs (+79 -17)
📝 src/api/identity.rs (+21 -25)
📝 src/db/models/organization.rs (+10 -0)

📄 Description

after a user's 2FA is removed, they should be deleted from all organizations where the 2fA policy is enforced.

fixes #3798


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/3803 **Author:** [@stefan0xC](https://github.com/stefan0xC) **Created:** 8/27/2023 **Status:** ✅ Merged **Merged:** 1/1/2024 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `enforce-2fa-policy-on-removal` --- ### 📝 Commits (3) - [`cb36ee5`](https://github.com/dani-garcia/vaultwarden/commit/cb36ee5415a021da7b8c3bc2019a833bbb172c85) enforce 2fa policy on removal of second factor - [`d5847e6`](https://github.com/dani-garcia/vaultwarden/commit/d5847e60a85ee8c59e938a39d6c3dd8a41c1a5ac) use &str instead of String in log_event() - [`8a8b0c7`](https://github.com/dani-garcia/vaultwarden/commit/8a8b0c727d8c6325100abf11f7cb49683424079f) enforce the 2fa policy on login ### 📊 Changes **7 files changed** (+163 additions, -122 deletions) <details> <summary>View changed files</summary> 📝 `src/api/admin.rs` (+8 -4) 📝 `src/api/core/ciphers.rs` (+8 -16) 📝 `src/api/core/events.rs` (+2 -2) 📝 `src/api/core/organizations.rs` (+35 -58) 📝 `src/api/core/two_factor/mod.rs` (+79 -17) 📝 `src/api/identity.rs` (+21 -25) 📝 `src/db/models/organization.rs` (+10 -0) </details> ### 📄 Description after a user's 2FA is removed, they should be deleted from all organizations where the 2fA policy is enforced. fixes #3798 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 05:22:48 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/vaultwarden#3310