[PR #2188] [MERGED] Add config option to set the HTTP redirect code for external icons #3289

New Issue

OVERLORD · 2025-10-09T18:20:35+03:00

OVERLORD commented

2025-10-09 18:20:35 +03:00

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/2188
Author: @jjlin
Created: 12/30/2021
Status: ✅ Merged
Merged: 1/3/2022
Merged by: @dani-garcia

Base: main ← Head: icons

📝 Commits (1)

b7eedbc Add config option to set the HTTP redirect code for external icons

📊 Changes

3 files changed (+28 additions, -3 deletions)

View changed files

📝 .env.template (+8 -1)
📝 src/api/icons.rs (+8 -1)
📝 src/config.rs (+12 -1)

📄 Description

The default code is 307 (temporary) to make it easier to test different icon services, but once a service has been decided on, users should ideally switch to using permanent redirects for cacheability.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/2188 **Author:** [@jjlin](https://github.com/jjlin) **Created:** 12/30/2021 **Status:** ✅ Merged **Merged:** 1/3/2022 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `icons` --- ### 📝 Commits (1) - [`b7eedbc`](https://github.com/dani-garcia/vaultwarden/commit/b7eedbcddc5bc52391472329fa6a43a2c9ae0a94) Add config option to set the HTTP redirect code for external icons ### 📊 Changes **3 files changed** (+28 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `.env.template` (+8 -1) 📝 `src/api/icons.rs` (+8 -1) 📝 `src/config.rs` (+12 -1) </details> ### 📄 Description The default code is 307 (temporary) to make it easier to test different icon services, but once a service has been decided on, users should ideally switch to using permanent redirects for cacheability. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2025-10-09 18:20:35 +03:00

OVERLORD closed this issue

2025-10-09 18:20:38 +03:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/vaultwarden#3289