[PR #3623] [MERGED] Added-External_id for Collections #3288

Closed
opened 2026-02-05 05:21:43 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/3623
Author: @fashberg
Created: 6/28/2023
Status: Merged
Merged: 7/4/2023
Merged by: @dani-garcia

Base: mainHead: main


📝 Commits (2)

📊 Changes

11 files changed (+36 additions, -8 deletions)

View changed files

migrations/mysql/2023-06-28-133700_add_collection_external_id/down.sql (+0 -0)
migrations/mysql/2023-06-28-133700_add_collection_external_id/up.sql (+1 -0)
migrations/postgresql/2023-06-28-133700_add_collection_external_id/down.sql (+0 -0)
migrations/postgresql/2023-06-28-133700_add_collection_external_id/up.sql (+1 -0)
migrations/sqlite/2023-06-28-133700_add_collection_external_id/down.sql (+0 -0)
migrations/sqlite/2023-06-28-133700_add_collection_external_id/up.sql (+1 -0)
📝 src/api/core/organizations.rs (+6 -3)
📝 src/db/models/collection.rs (+24 -5)
📝 src/db/schemas/mysql/schema.rs (+1 -0)
📝 src/db/schemas/postgresql/schema.rs (+1 -0)
📝 src/db/schemas/sqlite/schema.rs (+1 -0)

📄 Description

Hey maintainers!

Here is my 2nd PR, hope this gets merged now.

With incoming support for public api and groups vaultwarden gets ready for enterprise. What about imlementing ExternalId on collections?
It is supported for Groups and Orgs, but not yet for Collections. It's a big requirement for automated API Imports.

Feel Free to Comment and Update.

Kind Regards

Folke


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/3623 **Author:** [@fashberg](https://github.com/fashberg) **Created:** 6/28/2023 **Status:** ✅ Merged **Merged:** 7/4/2023 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (2) - [`6050c8d`](https://github.com/dani-garcia/vaultwarden/commit/6050c8dac50ad892d8ed8e00cd0c930c42dff039) Added-External_id for Collections - [`839b2bc`](https://github.com/dani-garcia/vaultwarden/commit/839b2bc950837999fbcb21c4dda0afc84d68d295) fix format error ### 📊 Changes **11 files changed** (+36 additions, -8 deletions) <details> <summary>View changed files</summary> ➕ `migrations/mysql/2023-06-28-133700_add_collection_external_id/down.sql` (+0 -0) ➕ `migrations/mysql/2023-06-28-133700_add_collection_external_id/up.sql` (+1 -0) ➕ `migrations/postgresql/2023-06-28-133700_add_collection_external_id/down.sql` (+0 -0) ➕ `migrations/postgresql/2023-06-28-133700_add_collection_external_id/up.sql` (+1 -0) ➕ `migrations/sqlite/2023-06-28-133700_add_collection_external_id/down.sql` (+0 -0) ➕ `migrations/sqlite/2023-06-28-133700_add_collection_external_id/up.sql` (+1 -0) 📝 `src/api/core/organizations.rs` (+6 -3) 📝 `src/db/models/collection.rs` (+24 -5) 📝 `src/db/schemas/mysql/schema.rs` (+1 -0) 📝 `src/db/schemas/postgresql/schema.rs` (+1 -0) 📝 `src/db/schemas/sqlite/schema.rs` (+1 -0) </details> ### 📄 Description Hey maintainers! Here is my 2nd PR, hope this gets merged now. With incoming support for public api and groups vaultwarden gets ready for enterprise. What about imlementing ExternalId on collections? It is supported for Groups and Orgs, but not yet for Collections. It's a big requirement for automated API Imports. Feel Free to Comment and Update. Kind Regards Folke --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 05:21:43 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/vaultwarden#3288