mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-07-16 05:34:10 +03:00
[PR #3623] [MERGED] Added-External_id for Collections #3288
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/dani-garcia/vaultwarden/pull/3623
Author: @fashberg
Created: 6/28/2023
Status: ✅ Merged
Merged: 7/4/2023
Merged by: @dani-garcia
Base:
main← Head:main📝 Commits (2)
6050c8dAdded-External_id for Collections839b2bcfix format error📊 Changes
11 files changed (+36 additions, -8 deletions)
View changed files
➕
migrations/mysql/2023-06-28-133700_add_collection_external_id/down.sql(+0 -0)➕
migrations/mysql/2023-06-28-133700_add_collection_external_id/up.sql(+1 -0)➕
migrations/postgresql/2023-06-28-133700_add_collection_external_id/down.sql(+0 -0)➕
migrations/postgresql/2023-06-28-133700_add_collection_external_id/up.sql(+1 -0)➕
migrations/sqlite/2023-06-28-133700_add_collection_external_id/down.sql(+0 -0)➕
migrations/sqlite/2023-06-28-133700_add_collection_external_id/up.sql(+1 -0)📝
src/api/core/organizations.rs(+6 -3)📝
src/db/models/collection.rs(+24 -5)📝
src/db/schemas/mysql/schema.rs(+1 -0)📝
src/db/schemas/postgresql/schema.rs(+1 -0)📝
src/db/schemas/sqlite/schema.rs(+1 -0)📄 Description
Hey maintainers!
Here is my 2nd PR, hope this gets merged now.
With incoming support for public api and groups vaultwarden gets ready for enterprise. What about imlementing ExternalId on collections?
It is supported for Groups and Orgs, but not yet for Collections. It's a big requirement for automated API Imports.
Feel Free to Comment and Update.
Kind Regards
Folke
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.