[PR #2429] [MERGED] Improve sync speed and updated dep. versions #3264

New Issue

OVERLORD · 2025-10-09T18:20:08+03:00

OVERLORD commented

2025-10-09 18:20:08 +03:00

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/2429
Author: @BlackDex
Created: 4/22/2022
Status: ✅ Merged
Merged: 5/11/2022
Merged by: @dani-garcia

Base: main ← Head: sql-optimizations

📝 Commits (1)

3ca8502 Improve sync speed and updated dep. versions

📊 Changes

38 files changed (+6252 additions, -6003 deletions)

View changed files

📝 .github/workflows/build.yml (+2 -2)
📝 .github/workflows/hadolint.yml (+3 -3)
📝 .github/workflows/release.yml (+3 -3)
📝 .pre-commit-config.yaml (+1 -1)
📝 Cargo.lock (+112 -119)
📝 Cargo.toml (+16 -14)
📝 docker/Dockerfile.j2 (+1 -1)
📝 docker/amd64/Dockerfile (+1 -1)
📝 docker/amd64/Dockerfile.buildx (+1 -1)
📝 docker/arm64/Dockerfile (+1 -1)
📝 docker/arm64/Dockerfile.buildx (+1 -1)
📝 docker/armv6/Dockerfile (+1 -1)
📝 docker/armv6/Dockerfile.buildx (+1 -1)
📝 docker/armv7/Dockerfile (+1 -1)
📝 docker/armv7/Dockerfile.buildx (+1 -1)
📝 rustfmt.toml (+3 -3)
📝 src/api/core/ciphers.rs (+94 -22)
📝 src/api/core/emergency_access.rs (+6 -3)
📝 src/api/core/mod.rs (+1 -0)
📝 src/api/core/organizations.rs (+9 -3)

...and 18 more files

📄 Description

Improved sync speed by resolving the N+1 query issues.
Solves #1402 and Solves #1453

With this change there is just one query done to retreive all the important data, and matching is done in-code/memory.
With a very large database the sync time went down about 3 times.

Also updated misc crates and Github Actions versions.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/2429 **Author:** [@BlackDex](https://github.com/BlackDex) **Created:** 4/22/2022 **Status:** ✅ Merged **Merged:** 5/11/2022 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `sql-optimizations` --- ### 📝 Commits (1) - [`3ca8502`](https://github.com/dani-garcia/vaultwarden/commit/3ca85028ea99ed43c99847b18e222f25ca47374e) Improve sync speed and updated dep. versions ### 📊 Changes **38 files changed** (+6252 additions, -6003 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build.yml` (+2 -2) 📝 `.github/workflows/hadolint.yml` (+3 -3) 📝 `.github/workflows/release.yml` (+3 -3) 📝 `.pre-commit-config.yaml` (+1 -1) 📝 `Cargo.lock` (+112 -119) 📝 `Cargo.toml` (+16 -14) 📝 `docker/Dockerfile.j2` (+1 -1) 📝 `docker/amd64/Dockerfile` (+1 -1) 📝 `docker/amd64/Dockerfile.buildx` (+1 -1) 📝 `docker/arm64/Dockerfile` (+1 -1) 📝 `docker/arm64/Dockerfile.buildx` (+1 -1) 📝 `docker/armv6/Dockerfile` (+1 -1) 📝 `docker/armv6/Dockerfile.buildx` (+1 -1) 📝 `docker/armv7/Dockerfile` (+1 -1) 📝 `docker/armv7/Dockerfile.buildx` (+1 -1) 📝 `rustfmt.toml` (+3 -3) 📝 `src/api/core/ciphers.rs` (+94 -22) 📝 `src/api/core/emergency_access.rs` (+6 -3) 📝 `src/api/core/mod.rs` (+1 -0) 📝 `src/api/core/organizations.rs` (+9 -3) _...and 18 more files_ </details> ### 📄 Description Improved sync speed by resolving the N+1 query issues. Solves #1402 and Solves #1453 With this change there is just one query done to retreive all the important data, and matching is done in-code/memory. With a very large database the sync time went down about 3 times. Also updated misc crates and Github Actions versions. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2025-10-09 18:20:09 +03:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/vaultwarden#3264