mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-02-05 00:29:40 +03:00
Logout if a manager role user opens settings of an organisation #323
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @kaotika on GitHub (Jun 17, 2019).
I added a user to an organisation with
userrights. I changed the users permissions tomanagerlater. If the user tries to open thesettingsmenu of the organisation, the user will be logged out with asession timed outmessage.Logs (
rustbacktrace=full)Another related issue:
After relogin in the same window, the vault is greyed out completely and no ui element is usable. The page is operational after a reload.
@mprasil commented on GitHub (Jun 17, 2019):
The "manager" permission level is not really supported in bitwarden_rs beyond very basic implementation that understands the order of privilege from
usertoowner. It is one of the feature requests in #246, but there isn't much traction as creating more organizations alleviates the need for more granular in-org permissions. (PR would be certainly welcome though)As for the broken UI, it got unexpected reply from the server, this tends to break the UI in general. As you noted, reload does restore the functionality.
What did you try to accomplish with manager level? Maybe there's some other way to do the same or maybe there's some subset of the API that we can extend to support manager level of access.
@kaotika commented on GitHub (Jun 17, 2019):
Ok, makes sense. I clicked on the collection name.
Maybe it's easier to hide the elements, that are not usable until they are fully implemented.
I intend to use it for a small team ~10 persons max, and I don't see a need for the
managerrole.@mprasil commented on GitHub (Jun 17, 2019):
We can't just hide these parts, because they are valid for users with higher level of access. I think we need to improve some API responses to either not expose some info to managers or to implement collection managing functionality for manager.
@mprasil commented on GitHub (Nov 11, 2019):
I think we can close this one as the question was answered.