[PR #3006] [MERGED] Fix a panic during Yubikey register/login #3177

New Issue

OVERLORD · 2026-02-05T05:16:38+03:00

OVERLORD commented

2026-02-05 05:16:38 +03:00

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/3006
Author: @BlackDex
Created: 12/18/2022
Status: ✅ Merged
Merged: 12/18/2022
Merged by: @dani-garcia

Base: main ← Head: fix-yubikey-panic

📝 Commits (1)

b60a4a6 Fix a panic during Yubikey register/login

📊 Changes

2 files changed (+9 additions, -7 deletions)

View changed files

📝 src/api/core/two_factor/yubikey.rs (+8 -6)
📝 src/api/identity.rs (+1 -1)

📄 Description

The yubico crate uses blocking reqwest, and we called the verify from a async thread. To prevent issues we need to wrap it within a spawn_blocking.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/3006 **Author:** [@BlackDex](https://github.com/BlackDex) **Created:** 12/18/2022 **Status:** ✅ Merged **Merged:** 12/18/2022 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `fix-yubikey-panic` --- ### 📝 Commits (1) - [`b60a4a6`](https://github.com/dani-garcia/vaultwarden/commit/b60a4a68c7858f54b1d49678c6314473ab873d21) Fix a panic during Yubikey register/login ### 📊 Changes **2 files changed** (+9 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/api/core/two_factor/yubikey.rs` (+8 -6) 📝 `src/api/identity.rs` (+1 -1) </details> ### 📄 Description The yubico crate uses blocking reqwest, and we called the `verify` from a async thread. To prevent issues we need to wrap it within a `spawn_blocking`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 05:16:38 +03:00

OVERLORD closed this issue

2026-02-05 05:16:41 +03:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/vaultwarden#3177