[PR #3363] [MERGED] Add support for Quay.io and GHCR.io as registries #3022

Closed
opened 2025-10-09 18:15:44 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/3363
Author: @BlackDex
Created: 3/23/2023
Status: Merged
Merged: 3/24/2023
Merged by: @dani-garcia

Base: mainHead: gha-test


📝 Commits (1)

  • 467ecfd Add support for Quay.io and GHCR.io as registries

📊 Changes

25 files changed (+175 additions, -55 deletions)

View changed files

📝 .github/workflows/build.yml (+3 -3)
📝 .github/workflows/hadolint.yml (+1 -1)
📝 .github/workflows/release.yml (+132 -18)
📝 docker/Dockerfile.j2 (+5 -5)
📝 docker/amd64/Dockerfile (+1 -1)
📝 docker/amd64/Dockerfile.alpine (+1 -1)
📝 docker/amd64/Dockerfile.buildkit (+1 -1)
📝 docker/amd64/Dockerfile.buildkit.alpine (+1 -1)
📝 docker/arm64/Dockerfile (+1 -1)
📝 docker/arm64/Dockerfile.alpine (+1 -1)
📝 docker/arm64/Dockerfile.buildkit (+1 -1)
📝 docker/arm64/Dockerfile.buildkit.alpine (+1 -1)
📝 docker/armv6/Dockerfile (+1 -1)
📝 docker/armv6/Dockerfile.alpine (+1 -1)
📝 docker/armv6/Dockerfile.buildkit (+1 -1)
📝 docker/armv6/Dockerfile.buildkit.alpine (+1 -1)
📝 docker/armv7/Dockerfile (+1 -1)
📝 docker/armv7/Dockerfile.alpine (+1 -1)
📝 docker/armv7/Dockerfile.buildkit (+1 -1)
📝 docker/armv7/Dockerfile.buildkit.alpine (+1 -1)

...and 5 more files

📄 Description

  • Added support for Quay.io
  • Added support for GHCR.io

To enable support for these container image registries the following needs to be added.

As Actions secrets and variables - Secrets

  • DOCKERHUB_TOKEN and DOCKERHUB_USERNAME
  • QUAY_TOKEN and QUAY_USERNAME

As Actions secrets and variables - Variables - Repository Variables

  • DOCKERHUB_REPO
  • GHCR_REPO
  • QUAY_REPO

The DOCKERHUB_REPO currently configured in Secrets can be removed if wanted, probably best after this PR has been merged.

If one of the vars/secrets are not configured it will skip that specific registry!


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/3363 **Author:** [@BlackDex](https://github.com/BlackDex) **Created:** 3/23/2023 **Status:** ✅ Merged **Merged:** 3/24/2023 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `gha-test` --- ### 📝 Commits (1) - [`467ecfd`](https://github.com/dani-garcia/vaultwarden/commit/467ecfdc999932963f70c06763ba75da5f8ce4d6) Add support for Quay.io and GHCR.io as registries ### 📊 Changes **25 files changed** (+175 additions, -55 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build.yml` (+3 -3) 📝 `.github/workflows/hadolint.yml` (+1 -1) 📝 `.github/workflows/release.yml` (+132 -18) 📝 `docker/Dockerfile.j2` (+5 -5) 📝 `docker/amd64/Dockerfile` (+1 -1) 📝 `docker/amd64/Dockerfile.alpine` (+1 -1) 📝 `docker/amd64/Dockerfile.buildkit` (+1 -1) 📝 `docker/amd64/Dockerfile.buildkit.alpine` (+1 -1) 📝 `docker/arm64/Dockerfile` (+1 -1) 📝 `docker/arm64/Dockerfile.alpine` (+1 -1) 📝 `docker/arm64/Dockerfile.buildkit` (+1 -1) 📝 `docker/arm64/Dockerfile.buildkit.alpine` (+1 -1) 📝 `docker/armv6/Dockerfile` (+1 -1) 📝 `docker/armv6/Dockerfile.alpine` (+1 -1) 📝 `docker/armv6/Dockerfile.buildkit` (+1 -1) 📝 `docker/armv6/Dockerfile.buildkit.alpine` (+1 -1) 📝 `docker/armv7/Dockerfile` (+1 -1) 📝 `docker/armv7/Dockerfile.alpine` (+1 -1) 📝 `docker/armv7/Dockerfile.buildkit` (+1 -1) 📝 `docker/armv7/Dockerfile.buildkit.alpine` (+1 -1) _...and 5 more files_ </details> ### 📄 Description - Added support for Quay.io - Added support for GHCR.io To enable support for these container image registries the following needs to be added. As `Actions secrets and variables` - `Secrets` - `DOCKERHUB_TOKEN` and `DOCKERHUB_USERNAME` - `QUAY_TOKEN` and `QUAY_USERNAME` As `Actions secrets and variables` - `Variables` - `Repository Variables` - `DOCKERHUB_REPO` - `GHCR_REPO` - `QUAY_REPO` The `DOCKERHUB_REPO` currently configured in `Secrets` can be removed if wanted, probably best after this PR has been merged. If one of the vars/secrets are not configured it will skip that specific registry! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2025-10-09 18:15:44 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/vaultwarden#3022