mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2025-12-11 09:13:02 +03:00
[PR #3398] always return KdfMemory and KdfParallelism #3018
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Original Pull Request: https://github.com/dani-garcia/vaultwarden/pull/3398
State: closed
Merged: Yes
As discussed in #3390 we could simplify the login logic a bit because the client will ignore the value of theses fields in case of
PBKDF2(whether they are unset or set to any value from trying outArgon2idas KDF)With
Argon2idthose fields should never benullbut always in a valid state. Be aware that if they arenullthe client will assume the bitwarden presets (i.e. m=64 and p=4) and if the fields are set to something else (not sure how this would happen but it's technically possible with a sqlite database) the login would most likely fail.So there should not be a reason to panic.
Disclaimer: I've only tested this change with the web-vault. Since this seems to be also the behavior of vault.bitwarden.com I'm assuming that the other clients will not behave differently in this regard.