[PR #3475] [MERGED] inline static rsa keys #2994

New Issue

Closed

opened 2025-10-09 18:15:12 +03:00 by OVERLORD · 0 comments

OVERLORD commented 2025-10-09 18:15:12 +03:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/3475
Author: @vilgotf
Created: 4/23/2023
Status: ✅ Merged
Merged: 4/24/2023
Merged by: @dani-garcia

Base: main ← Head: inline-statics

---

📝 Commits (1)

• 55c1b6e inline static rsa keys

📊 Changes

1 file changed (+5 additions, -8 deletions)

View changed files

📝 src/auth.rs (+5 -8)

📄 Description

From my understanding, rust never inlines static variables meaning that these variables are separately statically allocated and wasting space.

Even if there's not codegen diff, separately defining these static variables is (imo) code smell.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/3475 **Author:** [@vilgotf](https://github.com/vilgotf) **Created:** 4/23/2023 **Status:** ✅ Merged **Merged:** 4/24/2023 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `inline-statics` --- ### 📝 Commits (1) - [`55c1b6e`](https://github.com/dani-garcia/vaultwarden/commit/55c1b6e8d5860cded720b079de25e5de52cad026) inline static rsa keys ### 📊 Changes **1 file changed** (+5 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/auth.rs` (+5 -8) </details> ### 📄 Description From my understanding, rust never inlines static variables meaning that these variables are separately statically allocated and wasting space. Even if there's not codegen diff, separately defining these static variables is (imo) code smell. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

OVERLORD added the pull-request label 2025-10-09 18:15:12 +03:00

OVERLORD closed this issue 2025-10-09 18:15:14 +03:00

OVERLORD referenced this issue 2025-10-09 18:17:20 +03:00

[PR #2994] [MERGED] Fix recover-2fa not working. #3109

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

test_dylint

1.34.3

1.34.2

1.34.1

1.34.0

1.33.2

1.33.1

1.33.0

1.32.7

1.32.6

1.32.5

1.32.4

1.32.3

1.32.2

1.32.1

1.32.0

1.31.0

1.30.5

1.30.4

1.30.3

1.30.2

1.30.1

1.30.0

1.29.2

1.29.1

1.29.0

1.28.1

1.28.0

1.27.0

1.26.0

1.25.2

1.25.1

1.25.0

1.24.0

1.23.1

1.23.0

1.22.2

1.22.1

1.22.0

1.21.0

1.20.0

1.19.0

1.18.0

1.17.0

1.16.3

1.16.2

1.16.1

1.16.0

1.15.1

1.15.0

1.14.2

1.14.1

1.14

1.13.1

1.13.0

1.12.0

1.11.0

1.10.0

1.9.1

1.9.0

1.8.0

1.7.0

1.6.1

1.6.0

1.5.0

1.4.0

1.3.0

1.2.0

1.1.0

1.0.0

0.13.0

0.12.0

0.11.0

0.10.0

0.9.0

Labels

Clear labels

better for forum

bug

bug

bug

documentation

duplicate

enhancement

future Vault

good first issue

help wanted

low priority

notes

pull-request

Mirrored from GitHub Pull Request

question

SSO

Third party

troubleshooting

troubleshooting

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

OVERLORD

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/vaultwarden#2994