[PR #1913] [MERGED] Fix limitation on sharing ciphers with attachments #2989

New Issue

Closed

opened 2026-02-05 05:06:46 +03:00 by OVERLORD · 0 comments

OVERLORD commented 2026-02-05 05:06:46 +03:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/1913
Author: @jjlin
Created: 8/17/2021
Status: ✅ Merged
Merged: 8/22/2021
Merged by: @dani-garcia

Base: main ← Head: fix-attachment-sharing

---

📝 Commits (1)

• 56b4f46 Fix limitation on sharing ciphers with attachments

📊 Changes

2 files changed (+0 additions, -16 deletions)

View changed files

📝 src/api/core/ciphers.rs (+0 -6)
📝 src/db/models/attachment.rs (+0 -10)

📄 Description

This check is several years old, so maybe there was a valid reason for having it before, but it's not correct anymore.

Fixes #1909.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/1913 **Author:** [@jjlin](https://github.com/jjlin) **Created:** 8/17/2021 **Status:** ✅ Merged **Merged:** 8/22/2021 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `fix-attachment-sharing` --- ### 📝 Commits (1) - [`56b4f46`](https://github.com/dani-garcia/vaultwarden/commit/56b4f46d7d9c818a392d3ab62322302ed8b0c723) Fix limitation on sharing ciphers with attachments ### 📊 Changes **2 files changed** (+0 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `src/api/core/ciphers.rs` (+0 -6) 📝 `src/db/models/attachment.rs` (+0 -10) </details> ### 📄 Description This check is several years old, so maybe there was a valid reason for having it before, but it's not correct anymore. Fixes #1909. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

OVERLORD added the pull-request label 2026-02-05 05:06:46 +03:00

OVERLORD closed this issue 2026-02-05 05:06:49 +03:00

OVERLORD referenced this issue 2026-02-05 05:16:58 +03:00

[PR #3108] [MERGED] allow editing/unhiding by group #3184

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

cached-config-operations

test_dylint

1.35.4

1.35.3

1.35.2

1.35.1

1.35.0

1.34.3

1.34.2

1.34.1

1.34.0

1.33.2

1.33.1

1.33.0

1.32.7

1.32.6

1.32.5

1.32.4

1.32.3

1.32.2

1.32.1

1.32.0

1.31.0

1.30.5

1.30.4

1.30.3

1.30.2

1.30.1

1.30.0

1.29.2

1.29.1

1.29.0

1.28.1

1.28.0

1.27.0

1.26.0

1.25.2

1.25.1

1.25.0

1.24.0

1.23.1

1.23.0

1.22.2

1.22.1

1.22.0

1.21.0

1.20.0

1.19.0

1.18.0

1.17.0

1.16.3

1.16.2

1.16.1

1.16.0

1.15.1

1.15.0

1.14.2

1.14.1

1.14

1.13.1

1.13.0

1.12.0

1.11.0

1.10.0

1.9.1

1.9.0

1.8.0

1.7.0

1.6.1

1.6.0

1.5.0

1.4.0

1.3.0

1.2.0

1.1.0

1.0.0

0.13.0

0.12.0

0.11.0

0.10.0

0.9.0

Labels

Clear labels

SSO

Third party

better for forum

bug

bug

documentation

duplicate

enhancement

future Vault

future Vault

future Vault

good first issue

help wanted

low priority

notes

pull-request

Mirrored from GitHub Pull Request

question

troubleshooting

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

OVERLORD

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/vaultwarden#2989