[PR #3579] [CLOSED] Run mobile push requests in background #2972

New Issue

OVERLORD · 2025-10-09T18:14:47+03:00

OVERLORD commented

2025-10-09 18:14:47 +03:00

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/3579
Author: @quexten
Created: 6/13/2023
Status: ❌ Closed

Base: main ← Head: fix/mobile-push-in-background

📝 Commits (1)

e460643 Fix mobile push blocking requests and spamming push server

📊 Changes

7 files changed (+146 additions, -100 deletions)

View changed files

📝 src/api/admin.rs (+3 -3)
📝 src/api/core/accounts.rs (+5 -5)
📝 src/api/core/organizations.rs (+1 -1)
📝 src/api/core/sends.rs (+66 -16)
📝 src/api/notifications.rs (+12 -5)
📝 src/api/push.rs (+46 -69)
📝 src/db/models/device.rs (+13 -1)

📄 Description

Another partial fix for #3577.

Combining this with PR #3578, this should solve #3577.

Mobile push requests are currently run blocking within the HTTP Put for updating a cipher request. In the Bitwarden UI this just shows as if updating the entry takes up to multiple seconds. This request moves the actual HTTP request to the Bitwarden Push servers into a tokio task. This way, sending the notifications does not block the request to update a cipher.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/3579 **Author:** [@quexten](https://github.com/quexten) **Created:** 6/13/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/mobile-push-in-background` --- ### 📝 Commits (1) - [`e460643`](https://github.com/dani-garcia/vaultwarden/commit/e4606431d1f79133fe7d708736b4083e9adb8a01) Fix mobile push blocking requests and spamming push server ### 📊 Changes **7 files changed** (+146 additions, -100 deletions) <details> <summary>View changed files</summary> 📝 `src/api/admin.rs` (+3 -3) 📝 `src/api/core/accounts.rs` (+5 -5) 📝 `src/api/core/organizations.rs` (+1 -1) 📝 `src/api/core/sends.rs` (+66 -16) 📝 `src/api/notifications.rs` (+12 -5) 📝 `src/api/push.rs` (+46 -69) 📝 `src/db/models/device.rs` (+13 -1) </details> ### 📄 Description Another partial fix for #3577. Combining this with PR #3578, this should solve #3577. Mobile push requests are currently run blocking within the HTTP Put for updating a cipher request. In the Bitwarden UI this just shows as if updating the entry takes up to multiple seconds. This request moves the actual HTTP request to the Bitwarden Push servers into a tokio task. This way, sending the notifications does not block the request to update a cipher. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2025-10-09 18:14:47 +03:00

OVERLORD closed this issue

2025-10-09 18:14:48 +03:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/vaultwarden#2972