[PR #1220] [MERGED] Return 404 instead of fallback icon #2886

New Issue

Closed

opened 2026-02-05 05:02:09 +03:00 by OVERLORD · 0 comments

OVERLORD commented 2026-02-05 05:02:09 +03:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/1220
Author: @jameshurst
Created: 11/10/2020
Status: ✅ Merged
Merged: 11/14/2020
Merged by: @dani-garcia

Base: master ← Head: master

---

📝 Commits (2)

• ed70b07 Return 404 instead of fallback icon
• 7712331 Fix for negcached icons

📊 Changes

2 files changed (+16 additions, -18 deletions)

View changed files

📝 src/api/icons.rs (+16 -18)
➖ src/static/fallback-icon.png (+0 -0)

📄 Description

Returning a 404 not found error instead of the fallback icon allows clients to use their own icon instead (which may be higher quality than the fallback icon). This behaviour matches that of the official icons server as well (https://github.com/bitwarden/server/blob/master/src/Icons/Controllers/IconsController.cs#L89-L93).

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/1220 **Author:** [@jameshurst](https://github.com/jameshurst) **Created:** 11/10/2020 **Status:** ✅ Merged **Merged:** 11/14/2020 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`ed70b07`](https://github.com/dani-garcia/vaultwarden/commit/ed70b07d8184a6e5c3bb048af15386fb68b647c6) Return 404 instead of fallback icon - [`7712331`](https://github.com/dani-garcia/vaultwarden/commit/771233176fd108e0537c5dc5456c5c09cd8d1ef8) Fix for negcached icons ### 📊 Changes **2 files changed** (+16 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `src/api/icons.rs` (+16 -18) ➖ `src/static/fallback-icon.png` (+0 -0) </details> ### 📄 Description Returning a 404 not found error instead of the fallback icon allows clients to use their own icon instead (which may be higher quality than the fallback icon). This behaviour matches that of the official icons server as well (https://github.com/bitwarden/server/blob/master/src/Icons/Controllers/IconsController.cs#L89-L93). --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

OVERLORD added the pull-request label 2026-02-05 05:02:09 +03:00

OVERLORD closed this issue 2026-02-05 05:02:15 +03:00

OVERLORD referenced this issue 2026-02-05 05:14:52 +03:00

[PR #2886] [MERGED] redirect to admin login page when forward fails #3145

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

cached-config-operations

test_dylint

1.35.4

1.35.3

1.35.2

1.35.1

1.35.0

1.34.3

1.34.2

1.34.1

1.34.0

1.33.2

1.33.1

1.33.0

1.32.7

1.32.6

1.32.5

1.32.4

1.32.3

1.32.2

1.32.1

1.32.0

1.31.0

1.30.5

1.30.4

1.30.3

1.30.2

1.30.1

1.30.0

1.29.2

1.29.1

1.29.0

1.28.1

1.28.0

1.27.0

1.26.0

1.25.2

1.25.1

1.25.0

1.24.0

1.23.1

1.23.0

1.22.2

1.22.1

1.22.0

1.21.0

1.20.0

1.19.0

1.18.0

1.17.0

1.16.3

1.16.2

1.16.1

1.16.0

1.15.1

1.15.0

1.14.2

1.14.1

1.14

1.13.1

1.13.0

1.12.0

1.11.0

1.10.0

1.9.1

1.9.0

1.8.0

1.7.0

1.6.1

1.6.0

1.5.0

1.4.0

1.3.0

1.2.0

1.1.0

1.0.0

0.13.0

0.12.0

0.11.0

0.10.0

0.9.0

Labels

Clear labels

SSO

Third party

better for forum

bug

bug

documentation

duplicate

enhancement

future Vault

future Vault

future Vault

good first issue

help wanted

low priority

notes

pull-request

Mirrored from GitHub Pull Request

question

troubleshooting

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

OVERLORD

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/vaultwarden#2886