starred/vaultwarden
1
0
Fork 0
mirror of https://github.com/dani-garcia/vaultwarden.git synced 2025-12-09 09:13:02 +03:00
Code Issues 429 Packages Projects Releases 10 Wiki Activity

[PR #4153] [MERGED] Fix the version string #2880

New Issue
Closed
opened 2025-10-09 18:13:13 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2025-10-09 18:13:13 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/4153
Author: @BlackDex
Created: 12/9/2023
Status: ✅ Merged
Merged: 12/10/2023
Merged by: @dani-garcia

Base: main ← Head: fix-version-string

📝 Commits (1)

📊 Changes

9 files changed (+61 additions, -54 deletions)

View changed files

📝 .github/workflows/build.yml (+2 -2)
📝 Cargo.lock (+31 -31)
📝 Cargo.toml (+2 -2)
📝 build.rs (+7 -5)
📝 docker/DockerSettings.yaml (+2 -2)
📝 docker/Dockerfile.alpine (+7 -6)
📝 docker/Dockerfile.debian (+5 -3)
📝 docker/Dockerfile.j2 (+4 -2)
📝 rust-toolchain.toml (+1 -1)

📄 Description

For some reason still not known, the .git directory was not copied into the container. I think buildkit (buildx) did this by default before, and stopped this with newer versions.

This PR fixes this by also touching build.rs besides src/main.rs.

This PR also updates Rust to v1.74.1 and some crates, including the latest version of Alpine 3.19.

Fixes #4150

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/4153 **Author:** [@BlackDex](https://github.com/BlackDex) **Created:** 12/9/2023 **Status:** ✅ Merged **Merged:** 12/10/2023 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `fix-version-string` --- ### 📝 Commits (1) - [`f0d0a03`](https://github.com/dani-garcia/vaultwarden/commit/f0d0a03a611e5bba27ac58d1c32d49e91ee1703d) Fix the version string ### 📊 Changes **9 files changed** (+61 additions, -54 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build.yml` (+2 -2) 📝 `Cargo.lock` (+31 -31) 📝 `Cargo.toml` (+2 -2) 📝 `build.rs` (+7 -5) 📝 `docker/DockerSettings.yaml` (+2 -2) 📝 `docker/Dockerfile.alpine` (+7 -6) 📝 `docker/Dockerfile.debian` (+5 -3) 📝 `docker/Dockerfile.j2` (+4 -2) 📝 `rust-toolchain.toml` (+1 -1) </details> ### 📄 Description For some reason still not known, the `.git` directory was not copied into the container. I think buildkit (buildx) did this by default before, and stopped this with newer versions. This PR fixes this by also touching `build.rs` besides `src/main.rs`. This PR also updates Rust to v1.74.1 and some crates, including the latest version of Alpine 3.19. Fixes #4150 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2025-10-09 18:13:13 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
better for forum
bug
bug
bug
documentation
duplicate
enhancement
future Vault
good first issue
help wanted
low priority
notes
pull-request
Mirrored from GitHub Pull Request
 question
SSO
Third party
troubleshooting
troubleshooting
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/vaultwarden#2880
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?