starred/vaultwarden
1
0
Fork 0
mirror of https://github.com/dani-garcia/vaultwarden.git synced 2025-12-09 09:13:02 +03:00
Code Issues 429 Packages Projects Releases 10 Wiki Activity

[PR #4364] [CLOSED] Roll the refresh_token #2835

New Issue
Closed
opened 2025-10-09 18:12:25 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2025-10-09 18:12:25 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/4364
Author: @Timshel
Created: 2/18/2024
Status: ❌ Closed

Base: main ← Head: feature/rolling_refresh

📝 Commits (2)

  • fa3da1b Roll the refresh_token
  • d2e3bd8 Merge branch 'main' into feature/rolling_refresh

📊 Changes

1 file changed (+3 additions, -5 deletions)

View changed files

📝 src/db/models/device.rs (+3 -5)

📄 Description

Hey,

We recently discussed the refresh_token in the SSO PR and during this discussion it occurred to me that the long lived refresh_token could be rolled as is done by some SSO client.

This is handled / expected by the Bitwarden clients since the response _refresh_login contain the potentially updated refresh_token.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/4364 **Author:** [@Timshel](https://github.com/Timshel) **Created:** 2/18/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `feature/rolling_refresh` --- ### 📝 Commits (2) - [`fa3da1b`](https://github.com/dani-garcia/vaultwarden/commit/fa3da1bddb0d50dff44b28bc115bf3dc51bb9bf4) Roll the refresh_token - [`d2e3bd8`](https://github.com/dani-garcia/vaultwarden/commit/d2e3bd805ec49c961a22fac14306a367c9259953) Merge branch 'main' into feature/rolling_refresh ### 📊 Changes **1 file changed** (+3 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/db/models/device.rs` (+3 -5) </details> ### 📄 Description Hey, We recently discussed the `refresh_token` in the SSO PR and during this discussion it occurred to me that the long lived `refresh_token` could be rolled as is done by some SSO client. This is handled / expected by the Bitwarden clients since the response `_refresh_login` contain the potentially updated [refresh_token](https://github.com/dani-garcia/vaultwarden/blob/bb2412d0339e1da5dee99fc566a2b2aab5d2808c/src/api/identity.rs#L122). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2025-10-09 18:12:25 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
better for forum
bug
bug
bug
documentation
duplicate
enhancement
future Vault
good first issue
help wanted
low priority
notes
pull-request
Mirrored from GitHub Pull Request
 question
SSO
Third party
troubleshooting
troubleshooting
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/vaultwarden#2835
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?