[PR #4371] [CLOSED] JWT Refresh Token #2833

New Issue

OVERLORD · 2025-10-09T18:12:21+03:00

OVERLORD commented

2025-10-09 18:12:21 +03:00

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/4371
Author: @Timshel
Created: 2/21/2024
Status: ❌ Closed

Base: main ← Head: feature/jwt_refresh

📝 Commits (2)

7523e00 JWT Refresh Token
2467e91 Improve error message

📊 Changes

5 files changed (+257 additions, -111 deletions)

View changed files

📝 src/api/identity.rs (+51 -51)
📝 src/api/mod.rs (+1 -1)
📝 src/auth.rs (+198 -1)
📝 src/db/models/device.rs (+3 -58)
📝 src/error.rs (+4 -0)

📄 Description

To facilitate review decided to move out the switch to a JWT refresh_token from the sso PR https://github.com/dani-garcia/vaultwarden/pull/3899.

Without the SSO logic it's not the most useful still :

Add an expiration on the refresh_token (work like an idle timer reset when a new access_token is generated).
Store the information of the AuthMethod in the token (Password ...).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/4371 **Author:** [@Timshel](https://github.com/Timshel) **Created:** 2/21/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `feature/jwt_refresh` --- ### 📝 Commits (2) - [`7523e00`](https://github.com/dani-garcia/vaultwarden/commit/7523e00fbc0defd3bddbb7b7546387c640eaddba) JWT Refresh Token - [`2467e91`](https://github.com/dani-garcia/vaultwarden/commit/2467e9178a403a5b06cea4d80024578b735401cd) Improve error message ### 📊 Changes **5 files changed** (+257 additions, -111 deletions) <details> <summary>View changed files</summary> 📝 `src/api/identity.rs` (+51 -51) 📝 `src/api/mod.rs` (+1 -1) 📝 `src/auth.rs` (+198 -1) 📝 `src/db/models/device.rs` (+3 -58) 📝 `src/error.rs` (+4 -0) </details> ### 📄 Description To facilitate review decided to move out the switch to a JWT refresh_token from the sso PR https://github.com/dani-garcia/vaultwarden/pull/3899. Without the SSO logic it's not the most useful still : - Add an expiration on the `refresh_token` (work like an idle timer reset when a new access_token is generated). - Store the information of the `AuthMethod` in the token (`Password` ...). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2025-10-09 18:12:22 +03:00

OVERLORD closed this issue

2025-10-09 18:12:23 +03:00

OVERLORD referenced this issue

2025-10-09 18:18:17 +03:00

[PR #2834] [MERGED] Fix master password hint update not working. #3166

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/vaultwarden#2833