[PR #4592] [MERGED] add group support for Cipher::get_collections() #2782

New Issue

Open

opened 2025-10-09 18:11:28 +03:00 by OVERLORD · 0 comments

OVERLORD commented 2025-10-09 18:11:28 +03:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/4592
Author: @stefan0xC
Created: 5/26/2024
Status: ✅ Merged
Merged: 7/4/2024
Merged by: @dani-garcia

Base: main ← Head: fix-collection-permission-issue

---

📝 Commits (5)

• 49d07ed add group support for Cipher::get_collections()
• 37b2143 fix Collection::is_writable_by_user()
• e97088c differentiate the /collection endpoints
• 9af6f86 return cipherDetails on post_collections_update()
• a74c7bf add collections_v2 endpoint

📊 Changes

3 files changed (+267 additions, -74 deletions)

View changed files

📝 src/api/core/ciphers.rs (+92 -8)
📝 src/db/models/cipher.rs (+118 -25)
📝 src/db/models/collection.rs (+57 -41)

📄 Description

join group infos assigned to a collection to check whether user has been given access to all collections via any group or they have access to a specific collection via any group membership

fixes #4588

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/4592 **Author:** [@stefan0xC](https://github.com/stefan0xC) **Created:** 5/26/2024 **Status:** ✅ Merged **Merged:** 7/4/2024 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `fix-collection-permission-issue` --- ### 📝 Commits (5) - [`49d07ed`](https://github.com/dani-garcia/vaultwarden/commit/49d07ed5aae93b4282af63f1cee81fd53ea1d0fa) add group support for Cipher::get_collections() - [`37b2143`](https://github.com/dani-garcia/vaultwarden/commit/37b2143813906f9634021c52bf71bc81ee7b4d0d) fix Collection::is_writable_by_user() - [`e97088c`](https://github.com/dani-garcia/vaultwarden/commit/e97088c119771c69ca13f2ecb90ba9bd92b58f7b) differentiate the /collection endpoints - [`9af6f86`](https://github.com/dani-garcia/vaultwarden/commit/9af6f864df2133806622262e12f4df64cd3024d8) return cipherDetails on post_collections_update() - [`a74c7bf`](https://github.com/dani-garcia/vaultwarden/commit/a74c7bf20ffb212213129e9f70b860905a8f4290) add collections_v2 endpoint ### 📊 Changes **3 files changed** (+267 additions, -74 deletions) <details> <summary>View changed files</summary> 📝 `src/api/core/ciphers.rs` (+92 -8) 📝 `src/db/models/cipher.rs` (+118 -25) 📝 `src/db/models/collection.rs` (+57 -41) </details> ### 📄 Description join group infos assigned to a collection to check whether user has been given access to all collections via any group or they have access to a specific collection via any group membership fixes #4588 --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

OVERLORD added the pull-request label 2025-10-09 18:11:28 +03:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

test_dylint

1.34.3

1.34.2

1.34.1

1.34.0

1.33.2

1.33.1

1.33.0

1.32.7

1.32.6

1.32.5

1.32.4

1.32.3

1.32.2

1.32.1

1.32.0

1.31.0

1.30.5

1.30.4

1.30.3

1.30.2

1.30.1

1.30.0

1.29.2

1.29.1

1.29.0

1.28.1

1.28.0

1.27.0

1.26.0

1.25.2

1.25.1

1.25.0

1.24.0

1.23.1

1.23.0

1.22.2

1.22.1

1.22.0

1.21.0

1.20.0

1.19.0

1.18.0

1.17.0

1.16.3

1.16.2

1.16.1

1.16.0

1.15.1

1.15.0

1.14.2

1.14.1

1.14

1.13.1

1.13.0

1.12.0

1.11.0

1.10.0

1.9.1

1.9.0

1.8.0

1.7.0

1.6.1

1.6.0

1.5.0

1.4.0

1.3.0

1.2.0

1.1.0

1.0.0

0.13.0

0.12.0

0.11.0

0.10.0

0.9.0

Labels

Clear labels

better for forum

bug

bug

bug

documentation

duplicate

enhancement

future Vault

good first issue

help wanted

low priority

notes

pull-request

Mirrored from GitHub Pull Request

question

SSO

Third party

troubleshooting

troubleshooting

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

OVERLORD

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/vaultwarden#2782