[PR #4840] [MERGED] Remove unecessary email normalization #2719

New Issue

Closed

opened 2025-10-09 18:10:18 +03:00 by OVERLORD · 0 comments

OVERLORD commented 2025-10-09 18:10:18 +03:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/4840
Author: @Timshel
Created: 8/12/2024
Status: ✅ Merged
Merged: 8/17/2024
Merged by: @dani-garcia

Base: main ← Head: feature/email

---

📝 Commits (1)

• b895bed Remove unecessary email normalization

📊 Changes

1 file changed (+0 additions, -4 deletions)

View changed files

📝 src/api/core/two_factor/duo.rs (+0 -4)

📄 Description

Hey,

Was checking the OIDC pr change and realized that this change was still present.
I forgot to include it in the recent https://github.com/dani-garcia/vaultwarden/pull/4779.

Note that for stronger guaranty that the email is correctly formatted (would apply to duo_oidc.validate_duo_login too):

• Could change the parameter to User.
• Could define a custom type for a formatted email and wrap it.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/4840 **Author:** [@Timshel](https://github.com/Timshel) **Created:** 8/12/2024 **Status:** ✅ Merged **Merged:** 8/17/2024 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `feature/email` --- ### 📝 Commits (1) - [`b895bed`](https://github.com/dani-garcia/vaultwarden/commit/b895bedc6daed933ac35b348086eee3a684aecff) Remove unecessary email normalization ### 📊 Changes **1 file changed** (+0 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/api/core/two_factor/duo.rs` (+0 -4) </details> ### 📄 Description Hey, Was checking the OIDC pr change and realized that this change was still present. I forgot to include it in the recent https://github.com/dani-garcia/vaultwarden/pull/4779. Note that for stronger guaranty that the email is correctly formatted (would apply to `duo_oidc.validate_duo_login` too): - Could change the parameter to `User`. - Could define a custom type for a formatted email and wrap it. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

OVERLORD added the pull-request label 2025-10-09 18:10:18 +03:00

OVERLORD closed this issue 2025-10-09 18:10:20 +03:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

test_dylint

1.34.3

1.34.2

1.34.1

1.34.0

1.33.2

1.33.1

1.33.0

1.32.7

1.32.6

1.32.5

1.32.4

1.32.3

1.32.2

1.32.1

1.32.0

1.31.0

1.30.5

1.30.4

1.30.3

1.30.2

1.30.1

1.30.0

1.29.2

1.29.1

1.29.0

1.28.1

1.28.0

1.27.0

1.26.0

1.25.2

1.25.1

1.25.0

1.24.0

1.23.1

1.23.0

1.22.2

1.22.1

1.22.0

1.21.0

1.20.0

1.19.0

1.18.0

1.17.0

1.16.3

1.16.2

1.16.1

1.16.0

1.15.1

1.15.0

1.14.2

1.14.1

1.14

1.13.1

1.13.0

1.12.0

1.11.0

1.10.0

1.9.1

1.9.0

1.8.0

1.7.0

1.6.1

1.6.0

1.5.0

1.4.0

1.3.0

1.2.0

1.1.0

1.0.0

0.13.0

0.12.0

0.11.0

0.10.0

0.9.0

Labels

Clear labels

better for forum

bug

bug

bug

documentation

duplicate

enhancement

future Vault

good first issue

help wanted

low priority

notes

pull-request

Mirrored from GitHub Pull Request

question

SSO

Third party

troubleshooting

troubleshooting

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

OVERLORD

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/vaultwarden#2719