[PR #4968] [MERGED] remove backtics from postgresql migrations #2674

New Issue

Closed

opened 2025-10-09 18:09:29 +03:00 by OVERLORD · 0 comments

OVERLORD commented 2025-10-09 18:09:29 +03:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/4968
Author: @stefan0xC
Created: 9/19/2024
Status: ✅ Merged
Merged: 9/19/2024
Merged by: @BlackDex

Base: main ← Head: fix-postfix-migrations

---

📝 Commits (1)

• e3aa047 remove backtics from postgresql migrations

📊 Changes

2 files changed (+2 additions, -2 deletions)

View changed files

📝 migrations/postgresql/2024-09-04-091351_use_device_type_for_mails/down.sql (+1 -1)
📝 migrations/postgresql/2024-09-04-091351_use_device_type_for_mails/up.sql (+1 -1)

📄 Description

postgres does not support backtics for escaping keywords so we shouldn't use them in postgres migrations.
should fix the issue reported here: https://github.com/dani-garcia/vaultwarden/pull/4916#issuecomment-2361033931

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/4968 **Author:** [@stefan0xC](https://github.com/stefan0xC) **Created:** 9/19/2024 **Status:** ✅ Merged **Merged:** 9/19/2024 **Merged by:** [@BlackDex](https://github.com/BlackDex) **Base:** `main` ← **Head:** `fix-postfix-migrations` --- ### 📝 Commits (1) - [`e3aa047`](https://github.com/dani-garcia/vaultwarden/commit/e3aa047f31184f819b78d000b93c44f95c2595de) remove backtics from postgresql migrations ### 📊 Changes **2 files changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `migrations/postgresql/2024-09-04-091351_use_device_type_for_mails/down.sql` (+1 -1) 📝 `migrations/postgresql/2024-09-04-091351_use_device_type_for_mails/up.sql` (+1 -1) </details> ### 📄 Description postgres does [not support backtics for escaping keywords](https://wiki.postgresql.org/wiki/Things_to_find_out_about_when_moving_from_MySQL_to_PostgreSQL) so we shouldn't use them in postgres migrations. should fix the issue reported here: https://github.com/dani-garcia/vaultwarden/pull/4916#issuecomment-2361033931 --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

OVERLORD added the pull-request label 2025-10-09 18:09:29 +03:00

OVERLORD closed this issue 2025-10-09 18:09:30 +03:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

test_dylint

1.34.3

1.34.2

1.34.1

1.34.0

1.33.2

1.33.1

1.33.0

1.32.7

1.32.6

1.32.5

1.32.4

1.32.3

1.32.2

1.32.1

1.32.0

1.31.0

1.30.5

1.30.4

1.30.3

1.30.2

1.30.1

1.30.0

1.29.2

1.29.1

1.29.0

1.28.1

1.28.0

1.27.0

1.26.0

1.25.2

1.25.1

1.25.0

1.24.0

1.23.1

1.23.0

1.22.2

1.22.1

1.22.0

1.21.0

1.20.0

1.19.0

1.18.0

1.17.0

1.16.3

1.16.2

1.16.1

1.16.0

1.15.1

1.15.0

1.14.2

1.14.1

1.14

1.13.1

1.13.0

1.12.0

1.11.0

1.10.0

1.9.1

1.9.0

1.8.0

1.7.0

1.6.1

1.6.0

1.5.0

1.4.0

1.3.0

1.2.0

1.1.0

1.0.0

0.13.0

0.12.0

0.11.0

0.10.0

0.9.0

Labels

Clear labels

better for forum

bug

bug

bug

documentation

duplicate

enhancement

future Vault

good first issue

help wanted

low priority

notes

pull-request

Mirrored from GitHub Pull Request

question

SSO

Third party

troubleshooting

troubleshooting

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

OVERLORD

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/vaultwarden#2674