[PR #4977] [MERGED] Add extra linting #2672

New Issue

OVERLORD · 2025-10-09T18:09:25+03:00

OVERLORD commented

2025-10-09 18:09:25 +03:00

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/4977
Author: @BlackDex
Created: 9/21/2024
Status: ✅ Merged
Merged: 9/23/2024
Merged by: @dani-garcia

Base: main ← Head: update-lints-and-code

📝 Commits (2)

0cf7499 Add extra linting
46f89f3 Adjusted according to comments

📊 Changes

21 files changed (+82 additions, -70 deletions)

View changed files

📝 Cargo.lock (+10 -10)
📝 Cargo.toml (+23 -5)
📝 src/api/admin.rs (+3 -3)
📝 src/api/core/accounts.rs (+3 -3)
📝 src/api/core/organizations.rs (+1 -1)
📝 src/api/core/public.rs (+2 -2)
📝 src/api/core/two_factor/email.rs (+1 -1)
📝 src/api/core/two_factor/protected_actions.rs (+1 -1)
📝 src/api/core/two_factor/yubikey.rs (+1 -1)
📝 src/api/icons.rs (+10 -10)
📝 src/api/notifications.rs (+1 -1)
📝 src/auth.rs (+3 -3)
📝 src/config.rs (+3 -7)
📝 src/db/mod.rs (+2 -4)
📝 src/db/models/emergency_access.rs (+1 -1)
📝 src/db/models/organization.rs (+3 -3)
📝 src/db/models/user.rs (+2 -2)
📝 src/error.rs (+1 -1)
📝 src/http_client.rs (+3 -3)
📝 src/main.rs (+4 -4)

...and 1 more files

📄 Description

Added extra linting for some code styles.
Also added some of the Rust Edition 2024 lints since our MSRV does not yet support the group lint.
Once we reach 1.81.0 as MSRV we can uncomment it and use that lint.

Closes #4974

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/4977 **Author:** [@BlackDex](https://github.com/BlackDex) **Created:** 9/21/2024 **Status:** ✅ Merged **Merged:** 9/23/2024 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `update-lints-and-code` --- ### 📝 Commits (2) - [`0cf7499`](https://github.com/dani-garcia/vaultwarden/commit/0cf749903cb04214b7f9c484c8e512334adc6213) Add extra linting - [`46f89f3`](https://github.com/dani-garcia/vaultwarden/commit/46f89f320576dcef7ced7feb8140f7cdcd213b64) Adjusted according to comments ### 📊 Changes **21 files changed** (+82 additions, -70 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+10 -10) 📝 `Cargo.toml` (+23 -5) 📝 `src/api/admin.rs` (+3 -3) 📝 `src/api/core/accounts.rs` (+3 -3) 📝 `src/api/core/organizations.rs` (+1 -1) 📝 `src/api/core/public.rs` (+2 -2) 📝 `src/api/core/two_factor/email.rs` (+1 -1) 📝 `src/api/core/two_factor/protected_actions.rs` (+1 -1) 📝 `src/api/core/two_factor/yubikey.rs` (+1 -1) 📝 `src/api/icons.rs` (+10 -10) 📝 `src/api/notifications.rs` (+1 -1) 📝 `src/auth.rs` (+3 -3) 📝 `src/config.rs` (+3 -7) 📝 `src/db/mod.rs` (+2 -4) 📝 `src/db/models/emergency_access.rs` (+1 -1) 📝 `src/db/models/organization.rs` (+3 -3) 📝 `src/db/models/user.rs` (+2 -2) 📝 `src/error.rs` (+1 -1) 📝 `src/http_client.rs` (+3 -3) 📝 `src/main.rs` (+4 -4) _...and 1 more files_ </details> ### 📄 Description Added extra linting for some code styles. Also added some of the Rust Edition 2024 lints since our MSRV does not yet support the group lint. Once we reach 1.81.0 as MSRV we can uncomment it and use that lint. Closes #4974 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2025-10-09 18:09:26 +03:00

OVERLORD closed this issue

2025-10-09 18:09:27 +03:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/vaultwarden#2672