[PR #5339] Refactor the uri match fix and fix ssh-key sync #2610

New Issue

OVERLORD · 2025-10-09T18:08:11+03:00

OVERLORD commented

2025-10-09 18:08:11 +03:00

Original Pull Request: https://github.com/dani-garcia/vaultwarden/pull/5339

State: closed
Merged: Yes

Refactor uri match

Refactored the uri match fix to also convert numbers within a string to an int. If it fails it will be null.

Fix ssh-key sync

If any of the mandatory ssh-key json data values are not a string or are an empty string, this will break the mobile clients.
This commit fixes this by checking if any of the values are missing or invalid and converts the json data to null.
It will ensure the clients can sync and show the vault.

Fixes https://github.com/dani-garcia/vaultwarden/issues/5343
Fixes https://github.com/dani-garcia/vaultwarden/issues/5322

**Original Pull Request:** https://github.com/dani-garcia/vaultwarden/pull/5339 **State:** closed **Merged:** Yes --- ## Refactor uri match Refactored the uri match fix to also convert numbers within a string to an int. If it fails it will be null. ## Fix ssh-key sync If any of the mandatory ssh-key json data values are not a string or are an empty string, this will break the mobile clients. This commit fixes this by checking if any of the values are missing or invalid and converts the json data to `null`. It will ensure the clients can sync and show the vault. Fixes https://github.com/dani-garcia/vaultwarden/issues/5343 Fixes https://github.com/dani-garcia/vaultwarden/issues/5322

OVERLORD added the pull-request label 2025-10-09 18:08:11 +03:00

OVERLORD closed this issue

2025-10-09 18:08:13 +03:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/vaultwarden#2610