[PR #5491] [MERGED] Fix Duo Field Names for Web Client #2578

New Issue

OVERLORD · 2025-10-09T18:07:38+03:00

OVERLORD commented

2025-10-09 18:07:38 +03:00

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/5491
Author: @ratiner
Created: 1/28/2025
Status: ✅ Merged
Merged: 1/29/2025
Merged by: @BlackDex

Base: main ← Head: fix-duo-fields

📝 Commits (3)

9c1bf92 Fix Duo Field Names for Web Client
157dfcd Fix Api Validation
27665b1 Rename Duo Labels In Admin

📊 Changes

2 files changed (+13 additions, -13 deletions)

View changed files

📝 src/api/core/two_factor/duo.rs (+11 -11)
📝 src/config.rs (+2 -2)

📄 Description

Looks like the web client expects different fields for duo integration.
The changes were introduced in the following commit:
41e1d91558 (diff-2be3b52c1ad01eac329688bca2644e0aa1f819167ed8a9d52ed57f72e18b8aa8L4)
41e1d91558 (diff-8813d04cfcaad734e34e034e8a85eeb4a528d55aeb52b5c88e6bcbfced9fc260L13)

Web client sends different fields to the API (and also receives wrong ones):
clientSecret instead of secretKey and clientId instead of integrationKey

I believe, this PR can address this.

When saving:

When loading (Client Id and Client Secret is empty):

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/5491 **Author:** [@ratiner](https://github.com/ratiner) **Created:** 1/28/2025 **Status:** ✅ Merged **Merged:** 1/29/2025 **Merged by:** [@BlackDex](https://github.com/BlackDex) **Base:** `main` ← **Head:** `fix-duo-fields` --- ### 📝 Commits (3) - [`9c1bf92`](https://github.com/dani-garcia/vaultwarden/commit/9c1bf92a53822cd95ef996927d6efbf8952d08ff) Fix Duo Field Names for Web Client - [`157dfcd`](https://github.com/dani-garcia/vaultwarden/commit/157dfcd6e12e93eef2365cacef8143f77942993a) Fix Api Validation - [`27665b1`](https://github.com/dani-garcia/vaultwarden/commit/27665b1f53a83e318e9ef28e8287b8e010cd70da) Rename Duo Labels In Admin ### 📊 Changes **2 files changed** (+13 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `src/api/core/two_factor/duo.rs` (+11 -11) 📝 `src/config.rs` (+2 -2) </details> ### 📄 Description Looks like the web client expects different fields for duo integration. The changes were introduced in the following commit: https://github.com/bitwarden/clients/commit/41e1d9155850581be85d11e4b74088aa022f8381#diff-2be3b52c1ad01eac329688bca2644e0aa1f819167ed8a9d52ed57f72e18b8aa8L4 https://github.com/bitwarden/clients/commit/41e1d9155850581be85d11e4b74088aa022f8381#diff-8813d04cfcaad734e34e034e8a85eeb4a528d55aeb52b5c88e6bcbfced9fc260L13 Web client sends different fields to the API (and also receives wrong ones): `clientSecret` instead of `secretKey` and `clientId` instead of `integrationKey` I believe, this PR can address this. When saving: ![image](https://github.com/user-attachments/assets/21f13310-fce4-442f-baaa-df62d7bfc691) When loading (Client Id and Client Secret is empty): ![image](https://github.com/user-attachments/assets/dd70d557-4eaf-467e-b2ba-e2a03154be08) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2025-10-09 18:07:39 +03:00

OVERLORD closed this issue

2025-10-09 18:07:40 +03:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/vaultwarden#2578