[PR #6349] Add output dir option to backup command #2417

New Issue

OVERLORD · 2025-10-09T18:04:50+03:00

OVERLORD commented

2025-10-09 18:04:50 +03:00

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/6349
Author: @lukaspieper
Created: 10/8/2025
Status: 🔄 Open

Base: main ← Head: feature/backup-output-dir

📝 Commits (1)

0117670 Add output dir option to backup command

📊 Changes

3 files changed (+22 additions, -9 deletions)

View changed files

📝 src/api/admin.rs (+1 -1)
📝 src/db/mod.rs (+14 -3)
📝 src/main.rs (+7 -5)

📄 Description

Closes #6347, #5973

I added the CLI option as discussed in #6347. As I mentioned, I'm not familiar with Rust. I tested my changes to confirm they work, but I don't know anything about Rust best practices.

While implementing this, I noticed that there seem to be three ways to trigger the backup process: via the CLI, the USR1 signal or an API call. Bearing this in mind, I'm wondering whether the current approach is sensible, given that only the CLI will benefit from the change. Might it be more future-proof to add a config entry for the backup path instead of the CLI option to handle all three variants in the same way? For this reason, I am opening this as a draft to discuss this question.

Thanks in advance for spending time on my PR/feature request.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/6349 **Author:** [@lukaspieper](https://github.com/lukaspieper) **Created:** 10/8/2025 **Status:** 🔄 Open **Base:** `main` ← **Head:** `feature/backup-output-dir` --- ### 📝 Commits (1) - [`0117670`](https://github.com/dani-garcia/vaultwarden/commit/011767057c3f9b212b520aaf3f1efe6c31cb20ac) Add output dir option to backup command ### 📊 Changes **3 files changed** (+22 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `src/api/admin.rs` (+1 -1) 📝 `src/db/mod.rs` (+14 -3) 📝 `src/main.rs` (+7 -5) </details> ### 📄 Description Closes #6347, #5973 I added the CLI option as discussed in #6347. As I mentioned, I'm not familiar with Rust. I tested my changes to confirm they work, but I don't know anything about Rust best practices. While implementing this, I noticed that there seem to be three ways to trigger the backup process: via the CLI, the USR1 signal or an API call. Bearing this in mind, I'm wondering whether the current approach is sensible, given that only the CLI will benefit from the change. Might it be more future-proof to add a config entry for the backup path instead of the CLI option to handle all three variants in the same way? For this reason, I am opening this as a draft to discuss this question. Thanks in advance for spending time on my PR/feature request. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2025-10-09 18:04:50 +03:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/vaultwarden#2417