Website icons won't show. (Only the fallback icon does) #2393

New Issue

Closed

opened 2025-10-09 18:03:36 +03:00 by OVERLORD · 15 comments

OVERLORD commented 2025-10-09 18:03:36 +03:00

Owner

Copy Link

Originally created by @Ryonez on GitHub.

Been testing a little still, and have noticed that items don't show a icon related the the site saved in it.

Looking at the dev console shows:

I think there's a deeper issue though as navigating to the link that's meant to be to the image doesn't display anything:

This issue appears in the web vault, desktop and chrome browser clients.

Originally created by @Ryonez on GitHub. Been testing a little still, and have noticed that items don't show a icon related the the site saved in it. Looking at the dev console shows:  I think there's a deeper issue though as navigating to the link that's meant to be to the image doesn't display anything:  This issue appears in the web vault, desktop and chrome browser clients.

OVERLORD closed this issue 2025-10-09 18:03:37 +03:00

OVERLORD commented 2025-10-09 18:03:39 +03:00

Author

Owner

Copy Link

@dani-garcia commented on GitHub:

Strange, I did some testing and if I create an entry with a URL of www.google.com the icon loads, but if I use google.com instead, the web vault simply refuses to make the request at all (both in chrome and in firefox), I'll have to investigate some more. On the other side, the chrome extension works for me in my example, and so does making the request manually (opening http://localhost/icons/google.com/icon.png in the browser).

About your issue, does www.google.com work for you? By default we act as a proxy cache for the official icons service (at icons.bitwarden.com), so we don't do anything special.

@dani-garcia commented on GitHub: Strange, I did some testing and if I create an entry with a URL of `www.google.com` the icon loads, but if I use `google.com` instead, the web vault simply refuses to make the request at all (both in chrome and in firefox), I'll have to investigate some more. On the other side, the chrome extension works for me in my example, and so does making the request manually (opening `http://localhost/icons/google.com/icon.png` in the browser). About your issue, does `www.google.com` work for you? By default we act as a proxy cache for the official icons service (at `icons.bitwarden.com`), so we don't do anything special.

OVERLORD commented 2025-10-09 18:03:39 +03:00

Author

Owner

Copy Link

@mprasil commented on GitHub:

That's weird, the icons show just fine for me:

Anything relevant in the logs? Do you see any files in the icon_cache folder? (this folder should be besides the DB file by default)

@mprasil commented on GitHub: That's weird, the icons show just fine for me:  Anything relevant in the logs? Do you see any files in the `icon_cache` folder? (this folder should be besides the DB file by default)

OVERLORD commented 2025-10-09 18:03:39 +03:00

Author

Owner

Copy Link

@mprasil commented on GitHub:

Both google.com and www.google.com works for me.

GET /icons/google.com/icon.png:
    => Matched: GET /icons/<domain>/icon.png
Downloading icon for https://icons.bitwarden.com/google.com/icon.png...
    => Outcome: Success
    => Response succeeded.
GET /icons/www.google.com/icon.png:
    => Matched: GET /icons/<domain>/icon.png
Downloading icon for https://icons.bitwarden.com/www.google.com/icon.png...
    => Outcome: Success
    => Response succeeded.

Could there be some throttling somewhere, possibly on the icons.bitwarden.com side? I'd imagine if you import some sizable password library, the first time it loads, there's gonna be hundreds of requests created.

@mprasil commented on GitHub: Both google.com and www.google.com works for me. ``` GET /icons/google.com/icon.png: => Matched: GET /icons/<domain>/icon.png Downloading icon for https://icons.bitwarden.com/google.com/icon.png... => Outcome: Success => Response succeeded. GET /icons/www.google.com/icon.png: => Matched: GET /icons/<domain>/icon.png Downloading icon for https://icons.bitwarden.com/www.google.com/icon.png... => Outcome: Success => Response succeeded. ``` Could there be some throttling somewhere, possibly on the icons.bitwarden.com side? I'd imagine if you import some sizable password library, the first time it loads, there's gonna be hundreds of requests created.

OVERLORD commented 2025-10-09 18:03:39 +03:00

Author

Owner

Copy Link

@dani-garcia commented on GitHub:

Well it's trying to download the icons for google.com and discord.com, so if the icons_cache folder doesn't exist is because either the download failed or the saving to file failed.

I've modified the code to print the error in case the download failed, which I imagine is probably the cause. If with the new version there aren't still any error messages, I guess the other posibility is a permissions problem.

@mprasil Yeah, that was very weird, so it's probably a problem with my browser cache.

@dani-garcia commented on GitHub: Well it's trying to download the icons for `google.com` and `discord.com`, so if the `icons_cache` folder doesn't exist is because either the download failed or the saving to file failed. I've modified the code to print the error in case the download failed, which I imagine is probably the cause. If with the new version there aren't still any error messages, I guess the other posibility is a permissions problem. @mprasil Yeah, that was very weird, so it's probably a problem with my browser cache.

OVERLORD commented 2025-10-09 18:03:40 +03:00

Author

Owner

Copy Link

@Ryonez commented on GitHub:

The log shows this:

But the data folder is rather sparse. I only have this:

@Ryonez commented on GitHub: The log shows this:  But the data folder is rather sparse. I only have this: 

OVERLORD commented 2025-10-09 18:03:41 +03:00

Author

Owner

Copy Link

@Ryonez commented on GitHub:

Sorry @dani-garcia, I only just noticed your post.

I changed it to www.google.com, there's been no changes.
Is there meant to be a icon folder in the data dir? If so I don't have one.

To help further, I'm using the docker service.

Edit, seems the page wasn't loading my end. >.<

@Ryonez commented on GitHub: Sorry @dani-garcia, I only just noticed your post. I changed it to `www.google.com`, there's been no changes. Is there meant to be a icon folder in the data dir? If so I don't have one. To help further, I'm using the docker service. Edit, seems the page wasn't loading my end. >.<

OVERLORD commented 2025-10-09 18:03:41 +03:00

Author

Owner

Copy Link

@mprasil commented on GitHub:

@dani-garcia also a possibility, that creating the directory fails due to some FS permission issues, which then panics the call here before serving the icon to the client.

@mprasil commented on GitHub: @dani-garcia also a possibility, that creating the directory fails due to some FS permission issues, which then panics the call [here](https://github.com/dani-garcia/bitwarden_rs/blob/ea600ab2b84a4881daba70655d8c7aead83eb8d7/src/api/icons.rs#L86) before serving the icon to the client.

OVERLORD commented 2025-10-09 18:03:41 +03:00

Author

Owner

Copy Link

@dani-garcia commented on GitHub:

Okay, i tried in Docker and there seems to be a problem with the HTTPS connections, I'll see what I can do.

@dani-garcia commented on GitHub: Okay, i tried in Docker and there seems to be a problem with the HTTPS connections, I'll see what I can do.

OVERLORD commented 2025-10-09 18:03:42 +03:00

Author

Owner

Copy Link

@dani-garcia commented on GitHub:

I think I solved this, you should rebuild the docker container with the new changes.
If this works for you, please let me now!

@dani-garcia commented on GitHub: I think I solved this, you should rebuild the docker container with the new changes. If this works for you, please let me now!

OVERLORD commented 2025-10-09 18:03:42 +03:00

Author

Owner

Copy Link

@Ryonez commented on GitHub:

Rebuild, or update? I use the docker image you make.

@Ryonez commented on GitHub: Rebuild, or update? I use the docker image you make.

OVERLORD commented 2025-10-09 18:03:43 +03:00

Author

Owner

Copy Link

@mprasil commented on GitHub:

@dani-garcia this actually explains why it was working some time ago for me. I remember I had the same issue but it was first and foremost due to blocking any outgoing connections from bitwarden. Then I fixed that and it still didn't work, so I docker exec-ed into the container and installed curl to try the requests manually. As you'd probably figured out already, this installed certs as dependency and everything worked fine. (so I couldn't reproduce the issue) Bitwarden populated my icon cache and I haven't noticed it's not working since the cache was already there. 😄 What a tricky little bug.

@mprasil commented on GitHub: @dani-garcia this actually explains why it was working some time ago for me. I remember I had the same issue but it was first and foremost due to blocking any outgoing connections from bitwarden. Then I fixed that and it still didn't work, so I `docker exec`-ed into the container and installed `curl` to try the requests manually. As you'd probably figured out already, this installed certs as dependency and everything worked fine. (so I couldn't reproduce the issue) Bitwarden populated my icon cache and I haven't noticed it's not working since the cache was already there. :smile: What a tricky little bug.

OVERLORD commented 2025-10-09 18:03:43 +03:00

Author

Owner

Copy Link

@Ryonez commented on GitHub:

Of course, the repo has your name.
I'm probably way more tired than I feel.

I'll update once I see it come though.

@Ryonez commented on GitHub: Of course, the repo has your name. I'm probably way more tired than I feel. I'll update once I see it come though.

OVERLORD commented 2025-10-09 18:03:43 +03:00

Author

Owner

Copy Link

@Ryonez commented on GitHub:

Alright, updated the docker, and the icons are now present. Thank you very much for sorting this out!

Resolved by dfb348d630

@Ryonez commented on GitHub: Alright, updated the docker, and the icons are now present. Thank you very much for sorting this out! Resolved by dfb348d6303010c08b6ff4224da7be47ef268902

OVERLORD commented 2025-10-09 18:03:44 +03:00

Author

Owner

Copy Link

@mprasil commented on GitHub:

@Ryonez You're actually using my image. The build is scheduled, but takes about 1h to finish on slow Docker servers.

@mprasil commented on GitHub: @Ryonez You're actually using my image. The build is scheduled, but takes about 1h to finish on slow Docker servers.

OVERLORD commented 2025-10-09 18:03:44 +03:00

Author

Owner

Copy Link

@mprasil commented on GitHub:

You can follow the build status here.

@mprasil commented on GitHub: You can follow the [build status here](https://hub.docker.com/r/mprasil/bitwarden/builds/).

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

test_dylint

1.34.3

1.34.2

1.34.1

1.34.0

1.33.2

1.33.1

1.33.0

1.32.7

1.32.6

1.32.5

1.32.4

1.32.3

1.32.2

1.32.1

1.32.0

1.31.0

1.30.5

1.30.4

1.30.3

1.30.2

1.30.1

1.30.0

1.29.2

1.29.1

1.29.0

1.28.1

1.28.0

1.27.0

1.26.0

1.25.2

1.25.1

1.25.0

1.24.0

1.23.1

1.23.0

1.22.2

1.22.1

1.22.0

1.21.0

1.20.0

1.19.0

1.18.0

1.17.0

1.16.3

1.16.2

1.16.1

1.16.0

1.15.1

1.15.0

1.14.2

1.14.1

1.14

1.13.1

1.13.0

1.12.0

1.11.0

1.10.0

1.9.1

1.9.0

1.8.0

1.7.0

1.6.1

1.6.0

1.5.0

1.4.0

1.3.0

1.2.0

1.1.0

1.0.0

0.13.0

0.12.0

0.11.0

0.10.0

0.9.0

Labels

Clear labels

better for forum

bug

bug

bug

documentation

duplicate

enhancement

future Vault

good first issue

help wanted

low priority

notes

pull-request

Mirrored from GitHub Pull Request

question

SSO

Third party

troubleshooting

troubleshooting

wontfix

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

OVERLORD

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/vaultwarden#2393