starred/vaultwarden
1
0
Fork 0
mirror of https://github.com/dani-garcia/vaultwarden.git synced 2025-12-10 01:10:09 +03:00
Code Issues 429 Packages Projects Releases 10 Wiki Activity

in rocket 0.4 proxy remote ip has change #2266

New Issue
Closed
opened 2025-10-09 17:54:11 +03:00 by OVERLORD · 1 comment
OVERLORD commented 2025-10-09 17:54:11 +03:00
Owner
Copy Link

Originally created by @TMHBOFH on GitHub.

Hi,
with rocket 0.4 the function to get the remote ip has change.
Please see the changelog.

Request::remote() returns the actual remote IP, doesn't rewrite.

Use Request::real_ip() or Request::client_ip() to retrieve the IP address from the "X-Real-IP" header if it is present.

Thanks for your great work on this project.
best regards

Originally created by @TMHBOFH on GitHub. Hi, with rocket 0.4 the function to get the remote ip has change. Please see the [changelog](https://github.com/SergioBenitez/Rocket/blob/a4dcb0cf4cfd28671bbc8f101a99dfa1a74668b9/CHANGELOG.md). > Request::remote() returns the actual remote IP, doesn't rewrite. > > Use Request::real_ip() or Request::client_ip() to retrieve the IP address from the "X-Real-IP" header if it is present. Thanks for your great work on this project. best regards
OVERLORD added the good first issueenhancement labels 2025-10-09 17:54:11 +03:00
OVERLORD commented 2025-10-09 17:54:14 +03:00
Author
Owner
Copy Link

@dani-garcia commented on GitHub:

This should be fixed in the latest beta commit, good eye!

@dani-garcia commented on GitHub: This should be fixed in the latest beta commit, good eye!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
better for forum
bug
bug
bug
documentation
duplicate
enhancement
future Vault
good first issue
help wanted
low priority
notes
pull-request
Mirrored from GitHub Pull Request
 question
SSO
Third party
troubleshooting
troubleshooting
wontfix
No Label enhancement good first issue
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/vaultwarden#2266
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?