mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-02-05 00:29:40 +03:00
No Icons in Desktop Clients with Vaultwarden 1.33.0 #2150
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @miljw002 on GitHub (Jan 26, 2025).
Vaultwarden Support String
Your environment (Generated via diagnostics page)
Config & Details (Generated via diagnostics page)
Show Config & Details
Config:
Vaultwarden Build Version
1.33.0
Deployment method
Official Container Image
Custom deployment method
No response
Reverse Proxy
Caddy v2.9.1
Host/Server Operating System
NAS/SAN
Operating System Version
macOS 12.7.6
Clients
Desktop
Client Version
2025.1.3
Steps To Reproduce
Expected Result
Icons for websites.
Actual Result
a mixture of the default no icon and a broken image.
Logs
Screenshots or Videos
Reverting to 1.32.7 restores the icons.
Additional Context
No response
@miljw002 commented on GitHub (Jan 26, 2025):
Sorry, I forgot to include the icons do work in the Web Vault and with the iOS app.
I don't know why, but so far it's on the Bitwarden clients on Mac OS impacted. I've tried rolling back to previous versions of the Bitwarden client (thinking it was a client issue), and the older clients have the same problem (no icons).
@frankilla-m commented on GitHub (Jan 26, 2025):
The same goes for browser extensions. But iOS is OK.
@astounds commented on GitHub (Jan 26, 2025):
Same bug to browser extensions. But iOS and Android is ok
@BlackDex commented on GitHub (Jan 26, 2025):
I suspect it's the new security header I added to try to increase security. We might need to remove that, or maybe at least one for the icons. That's something i have to check.
@miljw002 commented on GitHub (Jan 26, 2025):
Thanks for the quick responses and it’s a relief it’s not just me.
What’s the security header change (without me trying to reverse engineer it)? I publish via Caddy, so may be able to adjust the headers there to test the theory.
@BlackDex commented on GitHub (Jan 26, 2025):
If you are able to prevent passing on this header
Cross-Origin-Resource-Policy, and best would be only if an url ends with/icon.png, that should do the job i think.In nginx it looks like this.
@Codelica commented on GitHub (Jan 26, 2025):
Thanks, that works for me.
@BlackDex commented on GitHub (Jan 26, 2025):
Thanks for confirming. Ill do some testing a bit further my self later today, and then probably make an exclusion for the icon endpoint to not return that header.
@Crash1602 commented on GitHub (Jan 26, 2025):
Thank you for the quick workaround. I have a question related to this topic, but I'm not sure if it would be a new issue. Therefore, I will briefly ask the question here first. If it's out of place, please just delete my post.
Using https://headerscan.com/ I scanned my Vaultwarden page and always receive the message that the Strict-Transport-Security header is not set, only for Vaultwarden, other Sites are fine. However, the following is configured on SWAG (Nginx):
A friend who uses the same system has the same problem. Therefore, the question is, what could be the reason for this?
Thank you very much!
@BlackDex commented on GitHub (Jan 26, 2025):
That is something you probably want to set your self to what ever is sane for you if your server/domain serves everything in https or not.
Vaultwarden does return such a header only if it does https it self, but then still you might not want subdomains or other duration.
I have that configured in my nginx for example.
@BlackDex commented on GitHub (Jan 26, 2025):
You can also use https://developer.mozilla.org/en-US/observatory which is nice.
@Brawl345 commented on GitHub (Jan 26, 2025):
Confirming that removing these lines works:
2903a3a13a/src/util.rs (L58)2903a3a13a/src/static/scripts/admin_diagnostics.js (L239)Removing the Cross-Origin-Resource-Policy header via Caddy did somehow not work (the icons throw a 404 in the Firefox add-on, the "Accept" header seems to be the problem but setting it via Caddy does nothing and I don't want to waste time debugging this and not sure whether it's my configuration or a bug).
@Crash1602 commented on GitHub (Jan 26, 2025):
Thank you very much for your response. I found my mistake. I had included the protocol (ex. https://) on the headerscan.com site, which probably led to the analysis not being carried out properly.
@Crash1602 commented on GitHub (Jan 26, 2025):
Thanks for the tip. Unfortunately, the site doesn't seem to handle it well if you deviate from the default 443 port. I use a different port than 443 for HTTPS, and as a result, the Mozilla site always recognizes my service as down - unfortunately :)
@tessus commented on GitHub (Jan 26, 2025):
For Apache reverse proxy setups, the following has to be put in the
VirtualHostsection:@walterzilla commented on GitHub (Jan 27, 2025):
Tried in Nginx Proxy Manager with no luck, icons still broken/not loading
Hints?
Thanks
@Eldaroth commented on GitHub (Jan 30, 2025):
Works for Traefik Reverse Proxy as well by adding a middleware to remove the header, for example via labels
@msebald commented on GitHub (Jan 31, 2025):
In HAProxy (through OPNsense) I put
http-response del-header Cross-Origin-Resource-Policyinto "Option pass-through" (enable advanced mode to see " Option pass-through").
Now I see icons again on my Windows Bitwarden client.
Will this be fixed? The issue is closed and Docker was updated recently and my container seems to be up-to-date. But I still did not see any icons until this addition to HAProxy today.
@BlackDex commented on GitHub (Jan 31, 2025):
Either use testing or wait for a new stable release.
@MrDoZo commented on GitHub (Jan 31, 2025):
So solved it via dynamic.yml in traefik:
I set priority for main router to 10.
Extra router only for icons:
middleware:
@flowoy96 commented on GitHub (Feb 2, 2025):
Have you been able to fix this? Also not working for me on NPM
@tessus commented on GitHub (Feb 2, 2025):
Did you see this?
This means the fix is in testing or github master.
@NeurekaSoftware commented on GitHub (Feb 3, 2025):
For those that want a fix now for Caddy, you can add the following to your Caddyfile:
Full Example: