Error trying manage a collection's users #213

New Issue

OVERLORD · 2026-02-04T18:38:45+03:00

OVERLORD commented

2026-02-04 18:38:45 +03:00

Originally created by @srwhite on GitHub (Jan 25, 2019).

If you view the collections for an organisation (https://server/#/organizations/.../manage/collections) you should be able to click on the "Cog" menu next to each one and manage the list of users.

With bitwarden_rs the pop-up dialog showing the user list never loads for me, instead my browser's console reports:

ERROR Error: Uncaught (in promise): TypeError: e.sent(...).map is not a function
TypeError: e.sent(...).map is not a function at vendor.0eaaec5bcaa0824c445b.js:121

I have something that appears to fix this, although I have spotted two other issues that I don't yet have have fixes for:

With my fix the users list appears, but none of the collections are "ticked" even if the user does have access to them
This functionality should be available to "Managers" as well as "Admin", but isn't in bitwarden_rs

Originally created by @srwhite on GitHub (Jan 25, 2019). If you view the collections for an organisation (https://server/#/organizations/.../manage/collections) you should be able to click on the "Cog" menu next to each one and manage the list of users. With bitwarden_rs the pop-up dialog showing the user list never loads for me, instead my browser's console reports: ``` ERROR Error: Uncaught (in promise): TypeError: e.sent(...).map is not a function TypeError: e.sent(...).map is not a function at vendor.0eaaec5bcaa0824c445b.js:121 ``` I have something that appears to fix this, although I have spotted two other issues that I don't yet have have fixes for: - With my fix the users list appears, but none of the collections are "ticked" even if the user does have access to them - This functionality should be available to "Managers" as well as "Admin", but isn't in bitwarden_rs

OVERLORD closed this issue

2026-02-04 18:38:50 +03:00

OVERLORD commented

2026-02-04 18:39:01 +03:00

@srwhite commented on GitHub (Jan 25, 2019):

The issue is that get_collection_users should return an array rather than a map. The contents of the array are not the values from the existing "user_list" variable, but should be simply a list of user Ids and whether they are read-only or not, i.e. if there is one user it would look like this (but with a real UUID):

[{"Id":"$$UUID$$","ReadOnly":false}]

@srwhite commented on GitHub (Jan 25, 2019): The issue is that get_collection_users should return an array rather than a map. The contents of the array are not the values from the existing "user_list" variable, but should be simply a list of user Ids and whether they are read-only or not, i.e. if there is one user it would look like this (but with a real UUID): ``` [{"Id":"$$UUID$$","ReadOnly":false}] ```

OVERLORD commented

2026-02-04 18:39:10 +03:00

@dani-garcia commented on GitHub (Jan 25, 2019):

About the users list, they appear selected for me correctly, but the save button doesn't work, that isn't implemented, same as the managers.

@dani-garcia commented on GitHub (Jan 25, 2019): About the users list, they appear selected for me correctly, but the save button doesn't work, that isn't implemented, same as the managers.

OVERLORD commented

2026-02-04 18:39:23 +03:00

@srwhite commented on GitHub (Jan 25, 2019):

Yeah, sorry, between the original report on here and making the pull request I worked out the fix for making the selections show up correctly.

I also note I failed to delete the line:

let user = User::find_by_uuid(&self.user_uuid, conn).unwrap();

from to_json_collection_user_details, which is now redundant as we don't need any of the extra details it obtains.

I'm interested in the manager functionality, so I might have a go at implementing it if I can find time.

@srwhite commented on GitHub (Jan 25, 2019): Yeah, sorry, between the original report on here and making the pull request I worked out the fix for making the selections show up correctly. I also note I failed to delete the line: ``` let user = User::find_by_uuid(&self.user_uuid, conn).unwrap(); ``` from to_json_collection_user_details, which is now redundant as we don't need any of the extra details it obtains. I'm interested in the manager functionality, so I might have a go at implementing it if I can find time.

OVERLORD commented

2026-02-04 18:39:30 +03:00

@dani-garcia commented on GitHub (Jan 25, 2019):

I pushed a fix for the unimplemented save from that dialog, so that should work now.

If you need any help with the implamentation of the manager functionality, I'm usually available in the matrix chat, link in readme.

With that, I think we can close this.

@dani-garcia commented on GitHub (Jan 25, 2019): I pushed a fix for the unimplemented save from that dialog, so that should work now. If you need any help with the implamentation of the manager functionality, I'm usually available in the matrix chat, link in readme. With that, I think we can close this.

OVERLORD referenced this issue

2026-02-05 04:51:13 +03:00

[PR #213] [MERGED] CollectionCipher::save() and delete() should return QueryResult instead of bool #2641

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/vaultwarden#213