When editing the cipher, can't change the folder to "No folder" #2

Closed
opened 2026-02-04 16:13:52 +03:00 by OVERLORD · 1 comment
Owner

Originally created by @mprasil on GitHub (Apr 19, 2018).

When editing cipher that's already in some folder, I can select No folder and click save.

Expected result is, that cipher will no longer be in any folder.

Actual result is, that the folder setting isn't updated.

I think there's extra check for None where it shouldn't be when updating the cipher, so when no folder id is provided in the post data (which is the case of selecting No folder) we don't update it. Might be a simple fix (I did something similar in the move handler) but first need to check if it won't affect some other functionality.

Originally created by @mprasil on GitHub (Apr 19, 2018). When editing cipher that's already in some folder, I can select `No folder` and click save. Expected result is, that cipher will no longer be in any folder. Actual result is, that the folder setting isn't updated. I think there's extra check for `None` where it shouldn't be when updating the cipher, so when no `folder id` is provided in the post data (which is the case of selecting `No folder`) we don't update it. Might be a simple fix (I did something similar in the move handler) but first need to check if it won't affect some other functionality.
Author
Owner

@dani-garcia commented on GitHub (Apr 19, 2018):

Thanks, I didn't notice that!
It should be fixed now with e6b6d7f

@dani-garcia commented on GitHub (Apr 19, 2018): Thanks, I didn't notice that! It should be fixed now with e6b6d7f
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/vaultwarden#2