mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-02-05 00:29:40 +03:00
Fail Sync at create a SecureNote #1922
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Crosus97 on GitHub (May 25, 2024).
Discussed in https://github.com/dani-garcia/vaultwarden/discussions/4554
This discussion a bug and i think this must be reviewed (read the last discussion comment)
Originally posted by Crosus97 May 15, 2024
Subject of the issue
when press de sync button apper a Fail Sync Error, that work until 3 o 4 days, no changes are made it
Your environment (Generated via diagnostics page)
Config (Generated via diagnostics page)
Show Running Config
Environment settings which are overridden: ADMIN_TOKEN
Steps to reproduce
I now detect than randomly sync, i think where the password must be sent on a field, the plugin automatically sync the database,
Expected behaviour
the plugin database must be synced
Actual behaviour
apper a sync error
Troubleshooting data
@BlackDex commented on GitHub (May 25, 2024):
I'm not sure what you expect here. You mentioned it was solved and now open a ticket again.
Please elaborate what your reason is. Also, this is missing a lot of info which was discussed in that discussion.
@Crosus97 commented on GitHub (May 25, 2024):
im reporting a bug(?)
At least I think so...
Is it normal that if I create a secure note within vaultwarden, the synchronization stops working? Maybe it's my misunderstanding, and it's not a bug?
i create a Secure Note
then the sync stop working
i explain in the in the discussion.
@Crosus97 commented on GitHub (May 25, 2024):
Maybe it's not the place to report a bug and it's my fault.
@BlackDex commented on GitHub (May 25, 2024):
Via which client, os, browser, phone etc.. please provide that kind of information
@tessus commented on GitHub (May 25, 2024):
according to #3580 it seems that vw (or the client) sometimes stores (or sends):
A solution was also suggested https://github.com/dani-garcia/vaultwarden/discussions/3580#discussioncomment-8137838
@BlackDex commented on GitHub (May 25, 2024):
@tessus but it would be good to know which client, what fields are filled which are not etc.. else is hard to reproduce if at all. It also might be something in between for example. Nothing to do with either Vaultwarden or Bitwarden even.
@Crosus97 commented on GitHub (May 26, 2024):
in my case ocurred with android client and with the chrome plugin, the bitwarden windows app work fine
@BlackDex commented on GitHub (May 26, 2024):
I used the android client just right now to add a secure note, and it sync's just fine afterwards.
Same goes for Chromium/Chrome, i can create a new secure note without any issues afterwards.
If you can reproduce this every time, then there must be something strange in between which causes the json to be changed?
Maybe the reverse proxy does something strange?
Can't be the database engine since that doesn't do anything special with json, and i use the same type.
I tested this both via nginx and haproxy, though for haproxy i just use tcp forwarding, not http, that might be able to do something with the input/output, but that would be weird too.
@Crosus97 commented on GitHub (May 26, 2024):
Timeline:
i maked this:
After 1 or 2 days I realized that my devices were not syncing.
Then I created the ticket, and it lasted as long as the ticket and the discussion lasted until the resolution date. As soon as I realized the problem, I deleted the secure note with the key, and it worked perfectly again
idk ¯_(ツ)_/¯
@BlackDex commented on GitHub (May 26, 2024):
But, does it happen again if you create a new secure note?
Was it an older note which caused this?
@BlackDex commented on GitHub (May 27, 2024):
It might be that some clients send wrong data, but in my memory that was only with very old clients and a buggy.
So, the current clients should just add correct data.
That makes me still wanting to know if this happens with the latest clients or not, since I'm not able to reproduce this without manually editing the database to start with. Not by using any client and adding a SecureNote.
Further could you check if there are more items like that.
If that returns one or more rows, then try to execute this query after making a backup of the database:
@tnorlin commented on GitHub (Jun 17, 2024):
I had this very same issue. Sync stopped working for both Android and iPhone client, I got one hit with the above query and I looked into my Securenotes and had one item created at that exact
created_atso I deleted that row (also from theBin) - after that I could sync again.