mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2025-12-09 17:23:04 +03:00
Organisation collections and websockets #1883
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @cybis on GitHub.
Subject of the issue
Websockets don't seem to be working when adding/editing entries within collections of an organisation. Websockets for entries outside an organisation are working fine. Anyone else observing this issue?
Your environment
Steps to reproduce
Create new entry within an organisation/collection in the browser extension/desktop app and check if the entry appears in the dekstop app/browser extension.
Expected behaviour
Entry appears instantly.
Actual behaviour
Entry does not appear.
@tomuta commented on GitHub:
Interestingly, this doesn't even work on vault.bitwarden.com. I found that the websocket notification is sending the wrong update type, which caused the web app to not fetch the new cipher. However, after fixing this, it seems like it now is fetching it, but it still doesn't update the web ui. I'm not sure what else might be wrong, it might be related to collections maybe. I noticed that on vault.bitwaden.com I have to check the
"Default collection" checkbox in order to be able to create an item (bitwarden_rs does not require this), but even if I do check it, it still doesn't work...@cybis commented on GitHub:
Organisations are a premium feature and not included in the free account. Judging by this old thread in the official forums, I'd say it might be an issue in the official implementation as well.
@tomuta commented on GitHub:
@CyBiS , it seems like it. Try registering a free account on bitwarden.com and see if you can replicate the issue there as well. Would be helpful to confirm.
@cybis commented on GitHub:
@tomuta thanks a lot for the confirmation. So is my understanding correct that this is also an issue with the official bitwarden server?
@tomuta commented on GitHub:
I did not have a premium account and was able to use (simple) organizations just fine with the free account. It may not be the full feature set, but I was able to reproduce (at least what I thought) what you saw there, too.
@BlackDex commented on GitHub:
I actually think this could be a bug/missing feature on our side.
We apparently do not send the collectionId with our websocket notify request.
It could very well be the issue.
This is something we need to look into.
@MartB commented on GitHub:
See:
462303e701/src/Core/Services/Implementations/NotificationHubPushNotificationService.cs (L53-L61)This might be part of the reason why it doesn't sync on the official bitwarden implementation.
@BlackDex commented on GitHub:
Since this is probably not something we can fix on our side, i will move this to discussions.
Also, it seems that currently websockets are broken at all on the bitwarden server side i tried to test it just now, and it doesn't work at all. There is also an issue regarding this: https://github.com/bitwarden/server/issues/1178
@cybis commented on GitHub:
Indeed, the free account allows for an organization with only 2 users and overall 2 collections. Thanks for pointing that out.
I can confirm that this bug is also present in the official implementation. Steps to reproduce:
The the
bitwarden_rsimplementation behaves similarly with the only exception that the snychronization within the folder isn't working either.@BlackDex commented on GitHub:
Well, it does indeed looks like they do not do that for new ciphers only added to a collection.
But still, they do add the CollectionIds sometimes, but only using the push services for the mobile clients if i'm correct.
So, i think we can not fix this on our side by just sending the id's with it. They have that disabled for a security reason it seems.