Parse bool values correctly #1846

New Issue

OVERLORD · 2025-10-09T17:32:43+03:00

OVERLORD commented

2025-10-09 17:32:43 +03:00

Originally created by @xoxys on GitHub.

Currently, uppercase bool values seems not to work e.g. SIGNUPS_ALLOWED=False which is really confusing and can lead to missconfigured public servers.

Normally, most common bool-ish string values like 1,0/yes,no/y,n/true,false/True,False should be converted to a real bool while reading env variables.

Originally created by @xoxys on GitHub. Currently, uppercase bool values seems not to work e.g. `SIGNUPS_ALLOWED=False` which is really confusing and can lead to missconfigured public servers. Normally, most common bool-ish string values like `1,0/yes,no/y,n/true,false/True,False` should be converted to a real bool while reading env variables.

OVERLORD closed this issue

2025-10-09 17:32:43 +03:00

OVERLORD commented

2025-10-09 17:32:46 +03:00

@dani-garcia commented on GitHub:

Should be fixed in d212dfe735 now.

@dani-garcia commented on GitHub: Should be fixed in https://github.com/dani-garcia/bitwarden_rs/commit/d212dfe735e59128667a4c579e52ce7e86b53a94 now.

OVERLORD commented

2025-10-09 17:32:47 +03:00

@xoxys commented on GitHub:

Cool, looks nice. Thanks for the fast fix.

@xoxys commented on GitHub: Cool, looks nice. Thanks for the fast fix.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/vaultwarden#1846