mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-02-05 00:29:40 +03:00
organization policy "remove personal vault" not applying when demoting member from admin / owner to user. #1825
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @iqfx on GitHub (Jan 20, 2024).
Subject of the issue
When updating a members role inside an organization to demote from admin / owner to user, any entries inside their personal vault are kept as is and are not moved to the organization vault / collection, breaking the policy. This is possible because as an admin / owner you are exempt from the "remove personal vault" policy, however when demoted a members personal vault does not get moved.
Deployment environment
Your environment (Generated via diagnostics page)
Config (Generated via diagnostics page)
Show Running Config
Environment settings which are overridden: SIGNUPS_ALLOWED, SMTP_HOST, SMTP_SSL, SMTP_PORT, SMTP_FROM, SMTP_USERNAME, SMTP_PASSWORD
Steps to reproduce
Expected behaviour
I expect any items in their personal vault get moved to the organization vault since the policy "remove personal vault" dictates that members that are not admin / owner of the organization are not allowed to have their own vault.
Actual behaviour
The users entries made in their personal vault that were created while they were owner stay in their personal vault and are not shared with the organization even though the policy says that as a member with the user role the user is not allowed to have a personal vault which they still have.
Troubleshooting data
@BlackDex commented on GitHub (Jan 20, 2024):
Those item's can not be transferred on the server-side, those items should be re-encrypted and shared with the organization.
The only thing we can do is purge the users vault, which is probably also not a good idea i think.
I actually do not know what the current behavior is on the Bitwarden instances.
@stefan0xC commented on GitHub (Jan 20, 2024):
That would give organization owners the possibility to read their co-owners passwords just by demoting them and activating this policy. So this should not work. (Also the data is protected via a key derived from their master password so it's technically impossible, I think.)
@stefan0xC commented on GitHub (Jan 20, 2024):
Just tested it: If this policy is active you cannot create new personal items or edit existing items in your personal vault.
@BlackDex commented on GitHub (Jan 20, 2024):
Closing this is works as intended