mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-02-05 00:29:40 +03:00
Not having an option to disable the websocket notification #1733
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @lyc8503 on GitHub (Oct 14, 2023).
Subject of the issue
After updating to v1.29.0, websockets are enabled by default on the HTTP port. But I'd like to disable that.
Steps to reproduce
Just run vaultwarden, and by default it enables Rocket WS which I don't find an option disable.
setting
WEBSOCKET_ENABLEDto false doesn't work as it stated in https://github.com/dani-garcia/vaultwarden/wiki/Enabling-WebSocket-notificationsExpected behaviour
Having a new option to forcibly disable the websocket feature.
Your environment (Generated via diagnostics page)
Config (Generated via diagnostics page)
Show Running Config
Environment settings which are overridden:
@BlackDex commented on GitHub (Oct 14, 2023):
That has no use. The clients will still try to connect. So why disable it at all?
If you want to do that, just block it in the reverse proxy.
It's not going to be a good idea do block this globally in my opinion.
@lyc8503 commented on GitHub (Oct 14, 2023):
Isn't there a way to tell the client there's no websocket support?
I have already tried to block the request in the reverse proxy and it worked, but I think maybe an option could be better.
I am deploying vaultwarden to a serverless platform, and it works well until the v1.29.0 update.
Websocket connections keeps the instance from sleeping and can cost a lot.
@NorthShad0w commented on GitHub (Oct 18, 2023):
@lyc8503 how did you block the
/notifications/hubrequests? I alse deployed the vaultwarden to the aliyun. Didn't find a way. Now I just set the timeout to1second to reduce the cost.@lyc8503 commented on GitHub (Oct 18, 2023):
It seems that deploying to serverless platforms like aliyun is not officially supported. So I use a little hack: I just bound the
/notifications/hubpath to another function which doesn't support websocket, then requests to that endpoint will be rejected by aliyun and costs nothing.@lyc8503 commented on GitHub (Oct 18, 2023):
As maintainers are not interested in this feature, closing this issue for now.
Workaround: block requests to
/notifications/hubvia reverse proxy or some platform-specific config