starred/vaultwarden
1
0
Fork 0
mirror of https://github.com/dani-garcia/vaultwarden.git synced 2026-03-01 11:19:52 +03:00
Code Issues 32 Packages Projects Releases 12 Wiki Activity

in rocket 0.4 proxy remote ip has change #149

New Issue
Closed
opened 2026-02-04 18:01:21 +03:00 by OVERLORD · 1 comment
OVERLORD commented 2026-02-04 18:01:21 +03:00
Owner
Copy Link

Originally created by @TMHBOFH on GitHub (Dec 9, 2018).

Hi,
with rocket 0.4 the function to get the remote ip has change.
Please see the changelog.

Request::remote() returns the actual remote IP, doesn't rewrite.

Use Request::real_ip() or Request::client_ip() to retrieve the IP address from the "X-Real-IP" header if it is present.

Thanks for your great work on this project.
best regards

Originally created by @TMHBOFH on GitHub (Dec 9, 2018). Hi, with rocket 0.4 the function to get the remote ip has change. Please see the [changelog](https://github.com/SergioBenitez/Rocket/blob/a4dcb0cf4cfd28671bbc8f101a99dfa1a74668b9/CHANGELOG.md). > Request::remote() returns the actual remote IP, doesn't rewrite. > > Use Request::real_ip() or Request::client_ip() to retrieve the IP address from the "X-Real-IP" header if it is present. Thanks for your great work on this project. best regards
OVERLORD added the enhancementgood first issue labels 2026-02-04 18:01:21 +03:00
OVERLORD commented 2026-02-04 18:01:48 +03:00
Author
Owner
Copy Link

@dani-garcia commented on GitHub (Dec 9, 2018):

This should be fixed in the latest beta commit, good eye!

@dani-garcia commented on GitHub (Dec 9, 2018): This should be fixed in the latest beta commit, good eye!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
SSO
Third party
better for forum
bug
bug
documentation
duplicate
enhancement
future Vault
future Vault
future Vault
good first issue
help wanted
low priority
notes
pull-request
Mirrored from GitHub Pull Request
 question
troubleshooting
wontfix
No Label enhancement good first issue
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/vaultwarden#149
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?