Global rules contains sonyentertainmentnetwork.com twice #1471

New Issue

Closed

opened 2026-02-05 01:02:16 +03:00 by OVERLORD · 1 comment

OVERLORD commented 2026-02-05 01:02:16 +03:00

Owner

Copy Link

Originally created by @nielsbasjes on GitHub (Jan 16, 2023).

The global domain rules contains sonyentertainmentnetwork.com in 2 lists.
Once with sony.com and once with playstation.com

https://github.com/dani-garcia/vaultwarden/blob/main/src/static/global_domains.json#L405
https://github.com/dani-garcia/vaultwarden/blob/main/src/static/global_domains.json#L897

To me it seems that these 3 should be combined into a single list.
Is my assessment correct?

Originally created by @nielsbasjes on GitHub (Jan 16, 2023). The global domain rules contains sonyentertainmentnetwork.com in 2 lists. Once with sony.com and once with playstation.com https://github.com/dani-garcia/vaultwarden/blob/main/src/static/global_domains.json#L405 https://github.com/dani-garcia/vaultwarden/blob/main/src/static/global_domains.json#L897 To me it seems that these 3 should be combined into a single list. Is my assessment correct?

OVERLORD closed this issue 2026-02-05 01:02:20 +03:00

OVERLORD commented 2026-02-05 01:02:24 +03:00

Author

Owner

Copy Link

@BlackDex commented on GitHub (Jan 16, 2023):

We use a tool 9b7e86efc2/tools/global_domains.py

Which extracts the data from the official Bitwarden data located here
https://github.com/bitwarden/server/blob/master/src/Core/Enums/GlobalEquivalentDomainsType.cs and https://github.com/bitwarden/server/blob/master/src/Core/Utilities/StaticStore.cs

Which states both, ans they have different main domains.
So i think it's valid. If you think otherwise, i suggest to report this at Bitwarden.

@BlackDex commented on GitHub (Jan 16, 2023): We use a tool https://github.com/dani-garcia/vaultwarden/blob/9b7e86efc23d6bbb5ee350160085ab8d8421d628/tools/global_domains.py Which extracts the data from the official Bitwarden data located here https://github.com/bitwarden/server/blob/master/src/Core/Enums/GlobalEquivalentDomainsType.cs and https://github.com/bitwarden/server/blob/master/src/Core/Utilities/StaticStore.cs Which states both, ans they have different main domains. So i think it's valid. If you think otherwise, i suggest to report this at Bitwarden.

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

cached-config-operations

test_dylint

1.35.2

1.35.1

1.35.0

1.34.3

1.34.2

1.34.1

1.34.0

1.33.2

1.33.1

1.33.0

1.32.7

1.32.6

1.32.5

1.32.4

1.32.3

1.32.2

1.32.1

1.32.0

1.31.0

1.30.5

1.30.4

1.30.3

1.30.2

1.30.1

1.30.0

1.29.2

1.29.1

1.29.0

1.28.1

1.28.0

1.27.0

1.26.0

1.25.2

1.25.1

1.25.0

1.24.0

1.23.1

1.23.0

1.22.2

1.22.1

1.22.0

1.21.0

1.20.0

1.19.0

1.18.0

1.17.0

1.16.3

1.16.2

1.16.1

1.16.0

1.15.1

1.15.0

1.14.2

1.14.1

1.14

1.13.1

1.13.0

1.12.0

1.11.0

1.10.0

1.9.1

1.9.0

1.8.0

1.7.0

1.6.1

1.6.0

1.5.0

1.4.0

1.3.0

1.2.0

1.1.0

1.0.0

0.13.0

0.12.0

0.11.0

0.10.0

0.9.0

Labels

Clear labels

SSO

Third party

better for forum

bug

bug

documentation

duplicate

enhancement

future Vault

future Vault

future Vault

good first issue

help wanted

low priority

notes

pull-request

Mirrored from GitHub Pull Request

question

troubleshooting

wontfix

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

OVERLORD

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/vaultwarden#1471