mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-02-28 03:12:50 +03:00
User with readonly access to collection entry can edit entry #145
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @0xERR0R on GitHub (Dec 7, 2018).
Environment: last docker version
Given: User A creates an item and shares it to the default collection of organization. User B has only readonly access to this Collection
When: User B opens the shared item, he can edit it (in web vault), which is wrong. The item should apper as read only item. User B can click on save and gets error "an unexpected error is occured". Server log: "ERROR: Cipher is not write accessible".
So this is only a UIproblem, the item can't be changed
@dani-garcia commented on GitHub (Dec 9, 2018):
So, I made a quick test in the official web vault and the ui acts the same way. The server sends a field
editwhich is true when the cipher is editable, but the ui doesn't seem to reflect it.For now, I fixed the errors in the latest beta so they show less generic messages in the clients.
@mprasil commented on GitHub (Dec 10, 2018):
I think we can close this as one part of the problem is upstream and the other was fixed in beta.