mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2025-12-09 09:13:02 +03:00
Unable to apply web build patch 2.19.0 #1432
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @hirodragon on GitHub.
Subject of the issue
Unable to apply web build patch 2.19.0 from https://github.com/dani-garcia/bw_web_builds/tree/master/patches
Deployment environment
Rasbian 10 (Buster)
1.19.0
Building own binary
Steps to reproduce
git clone https://github.com/bitwarden/web.git web-vault.gitcd web-vault.gitgit checkout v2.19.0curl -O https://raw.githubusercontent.com/dani-garcia/bw_web_builds/master/patches/v2.19.0.patchgit apply v2.19.0.patchExpected behaviour
Patch is applied.
Actual behaviour
Patch is not applied, error message occurs:
error: jslib/src/angular/components/register.component.ts: No such file or directoryerror: patch failed: src/app/services/services.module.ts:135error: src/app/services/services.module.ts: patch does not applySame behaviour for 2.18.1 patch, last patch succesfully applied was 2.18.0.
@Nyxtorm commented on GitHub:
I suggest a better solution :
git clone --recurse-submodules https://github.com/bitwarden/web.git web-vault.gitinstead of
git clone https://github.com/bitwarden/web.git web-vault.gitThis way, just one clone is enough, git will automatically get the submodules (so the jslib repository in this case)
EDIT : Moreover, the documentation is up to date on this subject: https://github.com/dani-garcia/bitwarden_rs/wiki/Building-binary#install-the-web-vault 😉
@Nyxtorm commented on GitHub:
Hello,
Your jslib folder should be empty. You should make a clone of the repository https://github.com/bitwarden/jslib.git and copy its contents to your empty web-vault's jslib folder.
For example :
Before, the jslib folder was included in the web-vault repository. He now has his own repository.
Sorry for my English and hoping to have helped.
EDIT : small correction in the rsync paths, but you can use any other copy tool (cp, etc ...)
@BlackDex commented on GitHub:
Or you can run the following command after a simple clone within the cloned folder: