Unable to apply web build patch 2.19.0 #1432

Closed
opened 2025-10-09 17:15:06 +03:00 by OVERLORD · 3 comments
Owner

Originally created by @hirodragon on GitHub.

Subject of the issue

Unable to apply web build patch 2.19.0 from https://github.com/dani-garcia/bw_web_builds/tree/master/patches

Deployment environment

Rasbian 10 (Buster)

  • bitwarden_rs version:
    1.19.0
  • Install method:
    Building own binary

Steps to reproduce

git clone https://github.com/bitwarden/web.git web-vault.git
cd web-vault.git
git checkout v2.19.0
curl -O https://raw.githubusercontent.com/dani-garcia/bw_web_builds/master/patches/v2.19.0.patch
git apply v2.19.0.patch

Expected behaviour

Patch is applied.

Actual behaviour

Patch is not applied, error message occurs:
error: jslib/src/angular/components/register.component.ts: No such file or directory
error: patch failed: src/app/services/services.module.ts:135
error: src/app/services/services.module.ts: patch does not apply
Same behaviour for 2.18.1 patch, last patch succesfully applied was 2.18.0.

Originally created by @hirodragon on GitHub. <!-- # ### NOTE: Please update to the latest version of bitwarden_rs before reporting an issue! This saves you and us a lot of time and troubleshooting. See: * https://github.com/dani-garcia/bitwarden_rs/issues/1180 * https://github.com/dani-garcia/bitwarden_rs/wiki/Updating-the-bitwarden-image # ### --> <!-- Please fill out the following template to make solving your problem easier and faster for us. This is only a guideline. If you think that parts are unnecessary for your issue, feel free to remove them. Remember to hide/redact personal or confidential information, such as passwords, IP addresses, and DNS names as appropriate. --> ### Subject of the issue Unable to apply web build patch 2.19.0 from https://github.com/dani-garcia/bw_web_builds/tree/master/patches ### Deployment environment Rasbian 10 (Buster) <!-- ========================================================================================= Preferably, use the `Generate Support String` button on the admin page's Diagnostics tab. That will auto-generate most of the info requested in this section. ========================================================================================= --> <!-- The version number, obtained from the logs (at startup) or the admin diagnostics page --> <!-- This is NOT the version number shown on the web vault, which is versioned separately from bitwarden_rs --> <!-- Remember to check if your issue exists on the latest version first! --> * bitwarden_rs version: 1.19.0 <!-- How the server was installed: Docker image, OS package, built from source, etc. --> * Install method: Building own binary ### Steps to reproduce <!-- Tell us how to reproduce this issue. What parameters did you set (differently from the defaults) and how did you start bitwarden_rs? --> `git clone https://github.com/bitwarden/web.git web-vault.git` `cd web-vault.git` `git checkout v2.19.0` `curl -O https://raw.githubusercontent.com/dani-garcia/bw_web_builds/master/patches/v2.19.0.patch` `git apply v2.19.0.patch` ### Expected behaviour <!-- Tell us what you expected to happen --> Patch is applied. ### Actual behaviour <!-- Tell us what actually happened --> Patch is not applied, error message occurs: `error: jslib/src/angular/components/register.component.ts: No such file or directory` `error: patch failed: src/app/services/services.module.ts:135` `error: src/app/services/services.module.ts: patch does not apply` Same behaviour for 2.18.1 patch, last patch succesfully applied was 2.18.0.
Author
Owner

@Nyxtorm commented on GitHub:

I suggest a better solution :

git clone --recurse-submodules https://github.com/bitwarden/web.git web-vault.git

instead of

git clone https://github.com/bitwarden/web.git web-vault.git

This way, just one clone is enough, git will automatically get the submodules (so the jslib repository in this case)

EDIT : Moreover, the documentation is up to date on this subject: https://github.com/dani-garcia/bitwarden_rs/wiki/Building-binary#install-the-web-vault 😉

@Nyxtorm commented on GitHub: I suggest a better solution : `git clone --recurse-submodules https://github.com/bitwarden/web.git web-vault.git` instead of `git clone https://github.com/bitwarden/web.git web-vault.git` This way, just one clone is enough, git will automatically get the submodules (so the jslib repository in this case) EDIT : Moreover, the documentation is up to date on this subject: https://github.com/dani-garcia/bitwarden_rs/wiki/Building-binary#install-the-web-vault 😉
Author
Owner

@Nyxtorm commented on GitHub:

Hello,

Your jslib folder should be empty. You should make a clone of the repository https://github.com/bitwarden/jslib.git and copy its contents to your empty web-vault's jslib folder.

For example :

git clone https://github.com/bitwarden/web.git web-vault.git
git clone https://github.com/bitwarden/jslib.git
rsync -rtlDvP  jslib.git/ web-vault.git/jslib/
cd web-vault.git
git checkout v2.19.0
curl -O https://raw.githubusercontent.com/dani-garcia/bw_web_builds/master/patches/v2.19.0.patch
git apply v2.19.0.patch

Before, the jslib folder was included in the web-vault repository. He now has his own repository.

Sorry for my English and hoping to have helped.

EDIT : small correction in the rsync paths, but you can use any other copy tool (cp, etc ...)

@Nyxtorm commented on GitHub: Hello, Your jslib folder should be empty. You should make a clone of the repository https://github.com/bitwarden/jslib.git and copy its contents to your empty web-vault's jslib folder. For example : ``` git clone https://github.com/bitwarden/web.git web-vault.git git clone https://github.com/bitwarden/jslib.git rsync -rtlDvP jslib.git/ web-vault.git/jslib/ cd web-vault.git git checkout v2.19.0 curl -O https://raw.githubusercontent.com/dani-garcia/bw_web_builds/master/patches/v2.19.0.patch git apply v2.19.0.patch ``` Before, the jslib folder was included in the web-vault repository. He now has his own repository. Sorry for my English and hoping to have helped. EDIT : small correction in the rsync paths, but you can use any other copy tool (cp, etc ...)
Author
Owner

@BlackDex commented on GitHub:

Or you can run the following command after a simple clone within the cloned folder:

git submodule update --init --recursive
@BlackDex commented on GitHub: Or you can run the following command after a simple clone within the cloned folder: ```bash git submodule update --init --recursive ```
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/vaultwarden#1432