mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-02-05 00:29:40 +03:00
Using a custom ROCKET_ADDRESS value results in erroneously reporting container as "Unhealthy" (healthcheck.sh) #1389
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ghost on GitHub (Oct 20, 2022).
Subject of the issue
healthcheck.sh ignores ROCKET_HOST value (if different from "localhost") and erroneously reports container as Unhealthy
Deployment environment
Docker installation of vaultwarden with a little customization (set ROCKET_HOST and ROCKET_PORT in the environment section of docker-compose).
vaultwarden version:
vaultwarden:latest
Install method:
docker / docker-compose
Steps to reproduce
Set ROCKET_HOST in docker-compose environment section for the container to a real local IP address (e.g. 192.168.1.1).
Set "network_mode: host" in docker-compose.
Start up the container.
After a few minutes, check container status with "docker ps".
Expected behaviour
"docker ps" reports container as "Healthy" if healthy, regardless of whether ROCKET_HOST is "localhost" or a different value.
Actual behaviour
"docker ps" reports container as "Unhealthy" if ROCKET_HOST value is different from "localhost".
Troubleshooting data
Issue stems from the very last line of /healthcheck.sh, which hardcodes "localhost" as the destination host for the curl call.
Is:
Should be (with the proper initialization of ROCKET_HOST earlier, of course):
Consequently, if Rocket doesn't listen on localhost:$ROCKET_PORT, but on (e.g.) 192.168.1.1:$ROCKET_PORT, the healthcheck will fail and the container will be reported as Unhealthy.
@jjlin commented on GitHub (Oct 20, 2022):
I assume you meant
ROCKET_ADDRESS, notROCKET_HOST? The latter isn't a thing, AFAIK. Anyway, #2844 should fix this.@ghost commented on GitHub (Oct 20, 2022):
Correct, ROCKET_ADDRESS. Tired when writing that. Love the super-quick fix.