mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-03-01 11:19:52 +03:00
Changes in #254 introduced dependency on rust-crypto which block build for AARCH64 #135
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @mprasil on GitHub (Nov 20, 2018).
The transitive dependency introduced in this PR blocks aarch64 builds.
@dani-garcia commented on GitHub (Nov 21, 2018):
rust-crypto is deprecated, we would need to have the yubico_rs crate migrated to something else. The recommendation in that thread is RustCrypto.
The easiest solution for now would be to put everything that uses the yubico_rs crate under a ´#[cfg(not(target_arch = "aarch64"))]`.
The best solution would obviously be to see if yubico_rs maintainer would accept a PR migrating to an alternative that is actively maintained, but I don't have the time available for it. So if someone wants to help with that, it would be greatly appreciated.
@mcrosson commented on GitHub (Jan 11, 2019):
@dani-garcia Would it be possible to have some kind of build option to turn off Yubikey support?
That would allow those of us on aarch64 the ability to build and run if not having Yubikey support is acceptable.
(I know I'd <3 to run bitwarden_rs and would gladly give up Yubikey support to be able to build/run)
@dani-garcia commented on GitHub (Jan 11, 2019):
Yo are right, I planned on making youkey functionality optional a long time ago and forgot completely. Should be fixed now with
1d034749f7@mcrosson commented on GitHub (Jan 11, 2019):
@dani-garcia it built on my end 👍 . Any chance you'd be willing to tag a release for those of us running builds on our own? I'd prefer to target your releases rather than master...
@dani-garcia commented on GitHub (Jan 11, 2019):
Sure, I already had a release prepared as a draft for the last couple days, as it's been a month since the last release (and over 80 commits). Might as well do it now.
https://github.com/dani-garcia/bitwarden_rs/releases/tag/1.6.0
@mprasil commented on GitHub (Jan 14, 2019):
This is now resolved.