Disable website icons setting was reset? #1343

Closed
opened 2026-02-05 00:40:05 +03:00 by OVERLORD · 3 comments
Owner

Originally created by @sfkpmr on GitHub (Aug 3, 2022).

Subject of the issue

Back in May I asked about how the website icons setting worked, and disabled it. Today I checked the logs and noticed that it had again downloaded icons, and in the UI I saw that all credentials had had icons downloaded.

Deployment environment

  • vaultwarden version: 1.25.0, now updated to 1.25.2
  • Install method: Docker Compose

    vaultwarden:
    image: vaultwarden/server
    container_name: vaultwarden
    environment:
    - TZ=${TZ}
    - SIGNUPS_ALLOWED=false
    volumes:
    - ./vaultwarden:/data
    security_opt:
    - no-new-privileges:true
    restart: unless-stopped

  • Clients used: Web, Android, Chromium add-on

  • Reverse proxy and version: Caddy 2.5.1

  • MySQL/MariaDB or PostgreSQL version:

  • Other relevant details:

Steps to reproduce

Disabled the website icons setting in May, now it's been reset.

Expected behaviour

Settings don't change automatically.

Actual behaviour

Setting changed on its own.

Troubleshooting data

Originally created by @sfkpmr on GitHub (Aug 3, 2022). ### Subject of the issue Back in May I [asked](https://github.com/dani-garcia/vaultwarden/discussions/2503) about how the website icons setting worked, and disabled it. Today I checked the logs and noticed that it had again downloaded icons, and in the UI I saw that all credentials had had icons downloaded. ### Deployment environment <!-- ========================================================================================= Preferably, use the `Generate Support String` button on the admin page's Diagnostics tab. That will auto-generate most of the info requested in this section. ========================================================================================= --> <!-- The version number, obtained from the logs (at startup) or the admin diagnostics page --> <!-- This is NOT the version number shown on the web vault, which is versioned separately from vaultwarden --> <!-- Remember to check if your issue exists on the latest version first! --> * vaultwarden version: 1.25.0, now updated to 1.25.2 <!-- How the server was installed: Docker image, OS package, built from source, etc. --> * Install method: Docker Compose vaultwarden: image: vaultwarden/server container_name: vaultwarden environment: - TZ=${TZ} - SIGNUPS_ALLOWED=false volumes: - ./vaultwarden:/data security_opt: - no-new-privileges:true restart: unless-stopped * Clients used: Web, Android, Chromium add-on * Reverse proxy and version: Caddy 2.5.1 * MySQL/MariaDB or PostgreSQL version: <!-- if applicable --> * Other relevant details: ### Steps to reproduce Disabled the website icons setting in May, now it's been reset. ### Expected behaviour Settings don't change automatically. ### Actual behaviour Setting changed on its own. ### Troubleshooting data <!-- Share any log files, screenshots, or other relevant troubleshooting data -->
Author
Owner

@BlackDex commented on GitHub (Aug 3, 2022):

@sfkpmr may i ask where you changed these settings?
If this was in the web-vault, then those are stored in the local storage/cookies of the browser, and thus if you clear that, or change hosts, or use a different browser, then those settings will not be there. Same for the web-vault theme for example.

@BlackDex commented on GitHub (Aug 3, 2022): @sfkpmr may i ask where you changed these settings? If this was in the web-vault, then those are stored in the local storage/cookies of the browser, and thus if you clear that, or change hosts, or use a different browser, then those settings will not be there. Same for the web-vault theme for example.
Author
Owner

@sfkpmr commented on GitHub (Aug 3, 2022):

@BlackDex Yes, I changed the settings at /#/settings/preferences in the web UI.

So, is there no way of setting this permanently?

I found this, can I set DISABLE_ICON_DOWNLOAD=false as an environment variable? Or true in my case.

@sfkpmr commented on GitHub (Aug 3, 2022): @BlackDex Yes, I changed the settings at /#/settings/preferences in the web UI. So, is there no way of setting this permanently? I found [this](https://github.com/dani-garcia/vaultwarden/blob/main/.env.template), can I set DISABLE_ICON_DOWNLOAD=false as an environment variable? Or true in my case.
Author
Owner

@BlackDex commented on GitHub (Aug 3, 2022):

Yes, that will prevent at least trying to fetch those icons. It will not prevent the clients from requesting them to download, and thus those requests will still end up into the reverse proxy logs.

But they will not be cached or stored locally.

@BlackDex commented on GitHub (Aug 3, 2022): Yes, that will prevent at least trying to fetch those icons. It will not prevent the clients from requesting them to download, and thus those requests will still end up into the reverse proxy logs. But they will not be cached or stored locally.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/vaultwarden#1343