mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-02-05 00:29:40 +03:00
CSP frame-ancestors doesn't include official desktop app #1310
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @LunNova on GitHub (Jun 30, 2022).
The bitwarden desktop app is at a file:// URL, so the frame-ancestors list prevents it from being framed.
This prevents the 2FA webauthn frame from working.
Is it safe to add
file://*to the frame-ancestors list in util.rs?The current content-security-policy used by the official web vault at https://vault.bitwarden.com doesn't set frame-ancestors.
Repro steps
Refused to frame ...error in developer tools@BlackDex commented on GitHub (Jun 30, 2022):
Vaultwarden also isn't sending the CSP headers for the connectors/mfa/2fa files served in some of the latter commits
Which version are you using of Vaultwarden? And did you tried the
testingtagged image and see if that solved it?@LunNova commented on GitHub (Jun 30, 2022):
It's working on
testing, wasn't on1.25.0, looks like5d05ec58bewas the fix.Sorry for the duplicate issue!
@BlackDex commented on GitHub (Jun 30, 2022):
No prob. Glad it works with that fix 🙂