mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-02-05 00:29:40 +03:00
Bug disappearance subfolders in left pane #1305
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Nyxtorm on GitHub (Jun 22, 2022).
Subject of the issue
Folders w/ subfolders disappear in left pane when I click on organization where I am the owner.
Deployment environment
Steps to reproduce
Expected behaviour / Actual behaviour
All folders should be displayed when I choose an organization in left pane
Troubleshooting data
Sorry for my English.
@BlackDex commented on GitHub (Jun 22, 2022):
Looks like this is an upstream issue, i see the same on the Official Bitwarden instances happening, though not with subfolders for me. But i see folders disappearing when clicking other organizations, also doesn't matter if I'm owner, admin, manager or user of an organization.
I'm afraid we can't fix this issue on the server side.
@Nyxtorm commented on GitHub (Jun 29, 2022):
Hello @BlackDex,
I tried to reproduce the problem on the official vault to open an issue but I can't reproduce it. Do you know if there is already an issue open for this?
Because unfortunately I don't have enough precise information to give them to try to correct this problem.
@BlackDex commented on GitHub (Jun 29, 2022):
@Nyxtorm When did you tried this?
They have just released a new version of the web-vault (which i was planning to patch for Vaultwarden in a few moments).
There are some fixes done there regarding filtering, which could have fixed the current bug :).
The current version is 2022.6.0, Vaultwarden latest now is 2022.5.2
@Nyxtorm commented on GitHub (Jun 29, 2022):
@BlackDex , indeed, I tested this morning on the official vault in 2022.6.0.
As the Bitwarden clients repository has been merged and the directory tree has changed, I have not yet been able to compile web vault with the latest available bw_web_builds git patch.
I'll test again as soon as the documentation is updated for the web-vault compilation or the next patch is released. :)
@BlackDex commented on GitHub (Jun 29, 2022):
@Nyxtorm i have created a PR for the web-vault: https://github.com/dani-garcia/bw_web_builds/pull/72
And i have updated the wiki: https://github.com/dani-garcia/vaultwarden/wiki/Building-binary#install-the-web-vault
@Nyxtorm commented on GitHub (Jun 29, 2022):
Thank you very much for your reactivity @BlackDex!
I'm in the process of testing with all this information (very manual way).
First problem (but not related to the Vaultwarden repository):
A GitHub repository is called in SSH instead of HTTPS, which can cause problems for those who don't have an SSH key on their GitHub account. I just edited this, I don't know if it can be added to the patch:
Then, everything is correct until the last step where an error occurs:
EDIT : Sorry! I didn't see the upgrade of NodeJS to v16! I don't have the second error anymore.
@Nyxtorm commented on GitHub (Jun 29, 2022):
I can confirm the documentation is correct for the build (very manual way) with the PR72, I'm well in 2022.6.0, unfortunately the problem of disappearing folders is still present. :(
@BlackDex commented on GitHub (Jun 29, 2022):
Regarding the git+ssh, that is probably something upstream is best to fix. It also doesn't seem to affect the Dockerfile build, which also does not have an SSH key, since that an anonymous user.
Regarding the issue it self, that is still an issue of Upstream it looks like, i tested it on an updated self-hosted
v2022.6.0version, and it also still happens there.It also happens if i use there build of the web-vault, which you can extract here: https://github.com/bitwarden/clients/releases/tag/web-v2022.6.0
Download the
web-2022.6.0-selfhosted-open-source.zip, extract the files within thebuildfolder to the web-vault folder.It will not have the Vaultwarden patches, but unless you use a sub-path, this should work with most functionality.
And there i have exactly the same. So, it looks like an issue on the web-vault it self.
@Nyxtorm commented on GitHub (Jun 29, 2022):
Thank you for all these details. I also noticed in the meantime that the problem occurs on the Windows client and even on the browser client Chrome (and possibly elsewhere).
The problem could be beyond the web vault (unless these clients only rely on the web vault part, I'm not expert enough to know that).
To be continued! :)
@BlackDex commented on GitHub (Jun 29, 2022):
If it also happens there it's a bug in the
jslibs, or rather thelibsdirectory currently in theclientsrepo.