Bug disappearance subfolders in left pane #1305

Closed
opened 2026-02-05 00:34:50 +03:00 by OVERLORD · 10 comments
Owner

Originally created by @Nyxtorm on GitHub (Jun 22, 2022).

Subject of the issue

Folders w/ subfolders disappear in left pane when I click on organization where I am the owner.

Deployment environment

  • Vaultwarden version: v1.25.0-887e320e (and tested with last PR 2567 as well)
  • Web-vault version: v2022.5.2
  • Running within Docker: false (Base: Debian)
  • Environment settings overridden: false
  • Uses a reverse proxy: true
  • IP Header check: true (X-Real-IP)
  • Internet access: true
  • Internet access via a proxy: false
  • DNS Check: true
  • Time Check: true
  • Domain Configuration Check: true
  • HTTPS Check: true
  • Database type: SQLite
  • Database version: 3.35.4
  • Clients used: Web, Android, Windows, Chrome, Firefox
  • Reverse proxy and version: Nginx 1.21.6
  • Other relevant information:

Steps to reproduce

  1. Have subfolders and basic folders in your vault with items
  2. In the "Vault" tab, we see the whole list of folders, including folders with subfolders in the left pane.
  3. Click on the organization you own in the top left pane
  4. Only folders with subfolders disappear from the listing in the left pane

Expected behaviour / Actual behaviour

All folders should be displayed when I choose an organization in left pane

Troubleshooting data

Sorry for my English.

Originally created by @Nyxtorm on GitHub (Jun 22, 2022). ### Subject of the issue Folders w/ subfolders disappear in left pane when I click on organization where I am the owner. ### Deployment environment * Vaultwarden version: v1.25.0-887e320e (and tested with last PR 2567 as well) * Web-vault version: v2022.5.2 * Running within Docker: false (Base: Debian) * Environment settings overridden: false * Uses a reverse proxy: true * IP Header check: true (X-Real-IP) * Internet access: true * Internet access via a proxy: false * DNS Check: true * Time Check: true * Domain Configuration Check: true * HTTPS Check: true * Database type: SQLite * Database version: 3.35.4 * Clients used: Web, Android, Windows, Chrome, Firefox * Reverse proxy and version: Nginx 1.21.6 * Other relevant information: ### Steps to reproduce 1. Have **subfolders** and basic folders in your vault with items 2. In the "Vault" tab, we see the whole list of folders, including folders with subfolders in the left pane. 3. Click on the organization you own in the top left pane 4. Only folders with subfolders disappear from the listing in the left pane ### Expected behaviour / Actual behaviour All folders should be displayed when I choose an organization in left pane ### Troubleshooting data Sorry for my English.
Author
Owner

@BlackDex commented on GitHub (Jun 22, 2022):

Looks like this is an upstream issue, i see the same on the Official Bitwarden instances happening, though not with subfolders for me. But i see folders disappearing when clicking other organizations, also doesn't matter if I'm owner, admin, manager or user of an organization.

I'm afraid we can't fix this issue on the server side.

@BlackDex commented on GitHub (Jun 22, 2022): Looks like this is an upstream issue, i see the same on the Official Bitwarden instances happening, though not with subfolders for me. But i see folders disappearing when clicking other organizations, also doesn't matter if I'm owner, admin, manager or user of an organization. I'm afraid we can't fix this issue on the server side.
Author
Owner

@Nyxtorm commented on GitHub (Jun 29, 2022):

Hello @BlackDex,

I tried to reproduce the problem on the official vault to open an issue but I can't reproduce it. Do you know if there is already an issue open for this?

Because unfortunately I don't have enough precise information to give them to try to correct this problem.

@Nyxtorm commented on GitHub (Jun 29, 2022): Hello @BlackDex, I tried to reproduce the problem on the official vault to open an issue but I can't reproduce it. Do you know if there is already an issue open for this? Because unfortunately I don't have enough precise information to give them to try to correct this problem.
Author
Owner

@BlackDex commented on GitHub (Jun 29, 2022):

@Nyxtorm When did you tried this?
They have just released a new version of the web-vault (which i was planning to patch for Vaultwarden in a few moments).
There are some fixes done there regarding filtering, which could have fixed the current bug :).

The current version is 2022.6.0, Vaultwarden latest now is 2022.5.2

@BlackDex commented on GitHub (Jun 29, 2022): @Nyxtorm When did you tried this? They have just released a new version of the web-vault (which i was planning to patch for Vaultwarden in a few moments). There are some fixes done there regarding filtering, which could have fixed the current bug :). The current version is 2022.6.0, Vaultwarden latest now is 2022.5.2
Author
Owner

@Nyxtorm commented on GitHub (Jun 29, 2022):

@BlackDex , indeed, I tested this morning on the official vault in 2022.6.0.

As the Bitwarden clients repository has been merged and the directory tree has changed, I have not yet been able to compile web vault with the latest available bw_web_builds git patch.

I'll test again as soon as the documentation is updated for the web-vault compilation or the next patch is released. :)

@Nyxtorm commented on GitHub (Jun 29, 2022): @BlackDex , indeed, I tested this morning on the official vault in 2022.6.0. As the Bitwarden clients repository has been merged and the directory tree has changed, I have not yet been able to compile web vault with the latest available bw_web_builds git patch. I'll test again as soon as the documentation is updated for the web-vault compilation or the next patch is released. :)
Author
Owner

@BlackDex commented on GitHub (Jun 29, 2022):

@Nyxtorm i have created a PR for the web-vault: https://github.com/dani-garcia/bw_web_builds/pull/72
And i have updated the wiki: https://github.com/dani-garcia/vaultwarden/wiki/Building-binary#install-the-web-vault

@BlackDex commented on GitHub (Jun 29, 2022): @Nyxtorm i have created a PR for the web-vault: https://github.com/dani-garcia/bw_web_builds/pull/72 And i have updated the wiki: https://github.com/dani-garcia/vaultwarden/wiki/Building-binary#install-the-web-vault
Author
Owner

@Nyxtorm commented on GitHub (Jun 29, 2022):

Thank you very much for your reactivity @BlackDex!

I'm in the process of testing with all this information (very manual way).

First problem (but not related to the Vaultwarden repository):

A GitHub repository is called in SSH instead of HTTPS, which can cause problems for those who don't have an SSH key on their GitHub account. I just edited this, I don't know if it can be added to the patch:

--- a/package-lock.json
+++ b/package-lock.json
@@ -21349,7 +21349,7 @@
     },
     "node_modules/duo_web_sdk": {
       "version": "2.7.0",
-      "resolved": "git+ssh://git@github.com/duosecurity/duo_web_sdk.git#f43ff8f1325f8630d0cff1cd9fb0df13d22cf28d",
+      "resolved": "https://git@github.com/duosecurity/duo_web_sdk.git#f43ff8f1325f8630d0cff1cd9fb0df13d22cf28d",
       "license": "SEE LICENSE IN LICENSE"
     },
     "node_modules/duplexer": {

Then, everything is correct until the last step where an error occurs:

$ npm run dist:oss:selfhost
                                                                                                                                                                                                                                                                                                                                                                                                           > @bitwarden/web-vault@2022.6.0 dist:oss:selfhost /data/vaultwarden/vw-compile/web-vault/apps/web                                                                                                                                         > npm run build:oss:selfhost:prod                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                     > @bitwarden/web-vault@2022.6.0 build:oss:selfhost:prod /data/vaultwarden/vw-compile/web-vault/apps/web                                                                                                                                   > cross-env ENV=selfhosted NODE_ENV=production npm run build:oss                                                                                                                                                                                                                                                                                                                                                                                                                                    sh: 1: cross-env: not found                                                                                                                                                                                                                       npm ERR! code ELIFECYCLE                                                                                                                                                                                                                          npm ERR! syscall spawn                                                                                                                                                                                                                            npm ERR! file sh                                                                                                                                                                                                                                  npm ERR! errno ENOENT                                                                                                                                                                                                                             npm ERR! @bitwarden/web-vault@2022.6.0 build:oss:selfhost:prod: `cross-env ENV=selfhosted NODE_ENV=production npm run build:oss`
npm ERR! spawn ENOENT                                                                                                                                                                                                                             npm ERR!
npm ERR! Failed at the @bitwarden/web-vault@2022.6.0 build:oss:selfhost:prod script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm WARN Local package.json exists, but node_modules missing, did you mean to install?

npm ERR! A complete log of this run can be found in:
npm ERR!     /data/vaultwarden/.npm/_logs/2022-06-29T14_50_09_000Z-debug.log
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @bitwarden/web-vault@2022.6.0 dist:oss:selfhost: `npm run build:oss:selfhost:prod`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the @bitwarden/web-vault@2022.6.0 dist:oss:selfhost script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm WARN Local package.json exists, but node_modules missing, did you mean to install?

npm ERR! A complete log of this run can be found in:
npm ERR!     /data/vaultwarden/.npm/_logs/2022-06-29T14_50_09_014Z-debug.log

EDIT : Sorry! I didn't see the upgrade of NodeJS to v16! I don't have the second error anymore.

@Nyxtorm commented on GitHub (Jun 29, 2022): Thank you very much for your reactivity @BlackDex! I'm in the process of testing with all this information (very manual way). First problem (but not related to the Vaultwarden repository): A GitHub repository is called in SSH instead of HTTPS, which can cause problems for those who don't have an SSH key on their GitHub account. I just edited this, I don't know if it can be added to the patch: ``` --- a/package-lock.json +++ b/package-lock.json @@ -21349,7 +21349,7 @@ }, "node_modules/duo_web_sdk": { "version": "2.7.0", - "resolved": "git+ssh://git@github.com/duosecurity/duo_web_sdk.git#f43ff8f1325f8630d0cff1cd9fb0df13d22cf28d", + "resolved": "https://git@github.com/duosecurity/duo_web_sdk.git#f43ff8f1325f8630d0cff1cd9fb0df13d22cf28d", "license": "SEE LICENSE IN LICENSE" }, "node_modules/duplexer": { ``` Then, everything is correct until the last step where an error occurs: ``` $ npm run dist:oss:selfhost > @bitwarden/web-vault@2022.6.0 dist:oss:selfhost /data/vaultwarden/vw-compile/web-vault/apps/web > npm run build:oss:selfhost:prod > @bitwarden/web-vault@2022.6.0 build:oss:selfhost:prod /data/vaultwarden/vw-compile/web-vault/apps/web > cross-env ENV=selfhosted NODE_ENV=production npm run build:oss sh: 1: cross-env: not found npm ERR! code ELIFECYCLE npm ERR! syscall spawn npm ERR! file sh npm ERR! errno ENOENT npm ERR! @bitwarden/web-vault@2022.6.0 build:oss:selfhost:prod: `cross-env ENV=selfhosted NODE_ENV=production npm run build:oss` npm ERR! spawn ENOENT npm ERR! npm ERR! Failed at the @bitwarden/web-vault@2022.6.0 build:oss:selfhost:prod script. npm ERR! This is probably not a problem with npm. There is likely additional logging output above. npm WARN Local package.json exists, but node_modules missing, did you mean to install? npm ERR! A complete log of this run can be found in: npm ERR! /data/vaultwarden/.npm/_logs/2022-06-29T14_50_09_000Z-debug.log npm ERR! code ELIFECYCLE npm ERR! errno 1 npm ERR! @bitwarden/web-vault@2022.6.0 dist:oss:selfhost: `npm run build:oss:selfhost:prod` npm ERR! Exit status 1 npm ERR! npm ERR! Failed at the @bitwarden/web-vault@2022.6.0 dist:oss:selfhost script. npm ERR! This is probably not a problem with npm. There is likely additional logging output above. npm WARN Local package.json exists, but node_modules missing, did you mean to install? npm ERR! A complete log of this run can be found in: npm ERR! /data/vaultwarden/.npm/_logs/2022-06-29T14_50_09_014Z-debug.log ``` EDIT : Sorry! I didn't see the upgrade of NodeJS to v16! I don't have the second error anymore.
Author
Owner

@Nyxtorm commented on GitHub (Jun 29, 2022):

I can confirm the documentation is correct for the build (very manual way) with the PR72, I'm well in 2022.6.0, unfortunately the problem of disappearing folders is still present. :(

@Nyxtorm commented on GitHub (Jun 29, 2022): I can confirm the documentation is correct for the build (very manual way) with the PR72, I'm well in 2022.6.0, unfortunately the problem of disappearing folders is still present. :(
Author
Owner

@BlackDex commented on GitHub (Jun 29, 2022):

Regarding the git+ssh, that is probably something upstream is best to fix. It also doesn't seem to affect the Dockerfile build, which also does not have an SSH key, since that an anonymous user.

Regarding the issue it self, that is still an issue of Upstream it looks like, i tested it on an updated self-hosted v2022.6.0 version, and it also still happens there.

It also happens if i use there build of the web-vault, which you can extract here: https://github.com/bitwarden/clients/releases/tag/web-v2022.6.0

Download the web-2022.6.0-selfhosted-open-source.zip, extract the files within the build folder to the web-vault folder.
It will not have the Vaultwarden patches, but unless you use a sub-path, this should work with most functionality.
And there i have exactly the same. So, it looks like an issue on the web-vault it self.

@BlackDex commented on GitHub (Jun 29, 2022): Regarding the git+ssh, that is probably something upstream is best to fix. It also doesn't seem to affect the Dockerfile build, which also does not have an SSH key, since that an anonymous user. Regarding the issue it self, that is still an issue of Upstream it looks like, i tested it on an updated self-hosted `v2022.6.0` version, and it also still happens there. It also happens if i use there build of the web-vault, which you can extract here: https://github.com/bitwarden/clients/releases/tag/web-v2022.6.0 Download the `web-2022.6.0-selfhosted-open-source.zip`, extract the files within the `build` folder to the web-vault folder. It will not have the Vaultwarden patches, but unless you use a sub-path, this should work with most functionality. And there i have exactly the same. So, it looks like an issue on the web-vault it self.
Author
Owner

@Nyxtorm commented on GitHub (Jun 29, 2022):

Thank you for all these details. I also noticed in the meantime that the problem occurs on the Windows client and even on the browser client Chrome (and possibly elsewhere).

The problem could be beyond the web vault (unless these clients only rely on the web vault part, I'm not expert enough to know that).

To be continued! :)

@Nyxtorm commented on GitHub (Jun 29, 2022): Thank you for all these details. I also noticed in the meantime that the problem occurs on the Windows client and even on the browser client Chrome (and possibly elsewhere). The problem could be beyond the web vault (unless these clients only rely on the web vault part, I'm not expert enough to know that). To be continued! :)
Author
Owner

@BlackDex commented on GitHub (Jun 29, 2022):

If it also happens there it's a bug in the jslibs, or rather the libs directory currently in the clients repo.

@BlackDex commented on GitHub (Jun 29, 2022): If it also happens there it's a bug in the `jslibs`, or rather the `libs` directory currently in the `clients` repo.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/vaultwarden#1305