mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2025-12-09 17:23:04 +03:00
Inviting users with capital letters in there mail address without mail enabled will fail to register #1304
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @frankenstein91 on GitHub.
Inviting users with capital letters in there mail address without mail enabled will fail to register
see Matrix chat for more information
@BlackDex commented on GitHub:
Confirmed.
The issue is that the mail addresses are not stored with lower-case letters within the invitations table.
Here: https://github.com/dani-garcia/vaultwarden/blob/main/src/db/models/user.rs#L352-L356 there is no conversion to lower-case, while here, https://github.com/dani-garcia/vaultwarden/blob/main/src/db/models/user.rs#L76-L79 it does.
And here are two different data paths used: https://github.com/dani-garcia/vaultwarden/blob/main/src/api/admin.rs#L269-L274
We need to make sure that all that info is lower-case stored and checked, and that the same data source is used for all items.
@BlackDex commented on GitHub:
Workaround for now: Invite users only with lower-case e-mail addresses.