mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2025-12-10 17:23:04 +03:00
1.23.0 Release - Web build 2.23.0c Stray Organization items #1276
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @cksapp on GitHub.
Latest Web build 2.23.0c contains stray fields when creating new Organization
When creating a new organization, New Organization page has additional option for "This account is owned by a business."
When selected multiple form fields come up which were not properly removed during web build process, these appear to be the :
When "This account is owned by a business" is deselected, Business Name field is removed but other form fields remain and prevent creation of Organization, requires page refresh or navigating to another Setting and back.
Deployment environment (Generated via diagnostics page)
Config (Generated via diagnostics page)
Show Running Config
Environment settings which are overridden: DOMAIN, TRASH_AUTO_DELETE_DAYS, SIGNUPS_ALLOWED, SIGNUPS_VERIFY, ORG_CREATION_USERS, SHOW_PASSWORD_HINT, ADMIN_TOKEN, INVITATION_ORG_NAME, SMTP_HOST, SMTP_EXPLICIT_TLS, SMTP_PORT, SMTP_FROM, SMTP_FROM_NAME, SMTP_USERNAME, SMTP_PASSWORD
Install method:
Clients used: Webclient
Reverse proxy and version: Caddy2
MySQL/MariaDB or PostgreSQL version: SQlite
Steps to reproduce
Under Settings > Organizations select button to create + New Organization

This account is owned by a business field is available, but not selected.
This account is owned by a business field is selected, additional form fields are now available.

This account is owned by a business field is unselected, but additional form fields are not removed.

If This account is owned by a business field is selected, then any data input into the form fields will give an error when creating the Org.

If selecting This account is owned by a business. field and then deselecting box form fields are left, requires at least Country filled to continue and produces the same error upon attempted Org creation.
Error message does not show up after failure and waiting, requires some type of page update, such as refresh (F5), or selecting another setting or clicking back to the Organizations tab.

Expected behavior
Disable This account is owned by a business. option when building web vault from upstream, similar to previous web build 2.21.1 to prevent additional form fields from being rendered, or allow for Organizations to be created with Business data (though I am not sure how applicable this would be)
@cksapp commented on GitHub:
Did not see any open issues, or PR associated with this. Did not check the bw_web_builds repo, only the main Vaulwarden code repo.
Glad to see someone else was already aware of this, and there is already a PR open to fix.
Awesome, thanks!
@jjlin commented on GitHub:
PR dani-garcia/bw_web_builds#54 is already open for this.