Password hint: An error has occurred. But does show. #1072

Closed
opened 2026-02-04 23:49:21 +03:00 by OVERLORD · 5 comments
Owner

Originally created by @Robin-Sch on GitHub (Jul 9, 2021).

Subject of the issue

When requesting your password hint it says An error has occurred..
But under that it does actually show the hint

Deployment environment

  • vaultwarden version: latest

  • Install method: docker

  • Clients used: web vault

Steps to reproduce

Click Get master password hint when trying to login
Enter your email

Expected behaviour

It should show your password hint

Actual behaviour

It shows your password hint, in an error box

Troubleshooting data

image

Originally created by @Robin-Sch on GitHub (Jul 9, 2021). ### Subject of the issue When requesting your password hint it says `An error has occurred.`. But under that it does actually show the hint ### Deployment environment * vaultwarden version: latest * Install method: docker * Clients used: web vault ### Steps to reproduce Click `Get master password hint` when trying to login Enter your email ### Expected behaviour It should show your password hint ### Actual behaviour It shows your password hint, in an error box ### Troubleshooting data ![image](https://user-images.githubusercontent.com/46354497/125095957-fa2eed00-e0d4-11eb-9045-a111e38b993e.png)
Author
Owner

@jjlin commented on GitHub (Jul 9, 2021):

Normally, BItwarden only provides the password hint via email. This is a Vaultwarden-specific feature that allows the hint to be provided when the user hasn't set up email service:

3968bc8016/src/config.rs (L391-L393)

Though personally, I think this option should've been disabled by default.

@jjlin commented on GitHub (Jul 9, 2021): Normally, BItwarden only provides the password hint via email. This is a Vaultwarden-specific feature that allows the hint to be provided when the user hasn't set up email service: https://github.com/dani-garcia/vaultwarden/blob/3968bc8016611cdf9a84db68990f27624ab17889/src/config.rs#L391-L393 Though personally, I think this option should've been disabled by default.
Author
Owner

@pepa65 commented on GitHub (Jul 10, 2021):

Yes, please disable by default!

@pepa65 commented on GitHub (Jul 10, 2021): Yes, please disable by default!
Author
Owner

@Robin-Sch commented on GitHub (Jul 13, 2021):

Normally, BItwarden only provides the password hint via email. This is a Vaultwarden-specific feature that allows the hint to be provided when the user hasn't set up email service:

Yeah, but the current way is that it shows as "An error has occurred", and as "error" the password hint. While it's not an error?

@Robin-Sch commented on GitHub (Jul 13, 2021): > Normally, BItwarden only provides the password hint via email. This is a Vaultwarden-specific feature that allows the hint to be provided when the user hasn't set up email service: Yeah, but the current way is that it shows as "An error has occurred", and as "error" the password hint. While it's not an error?
Author
Owner

@jjlin commented on GitHub (Jul 13, 2021):

It's not an error, but Bitwarden doesn't support this feature natively, so this is a Vaultwarden-specific hack that uses an error message to display the data. That's just the only way to do it.

#1848 will disable this setting by default. People who want password hints should just set up SMTP service and use that instead, anyway.

@jjlin commented on GitHub (Jul 13, 2021): It's not an error, but Bitwarden doesn't support this feature natively, so this is a Vaultwarden-specific hack that uses an error message to display the data. That's just the only way to do it. #1848 will disable this setting by default. People who want password hints should just set up SMTP service and use that instead, anyway.
Author
Owner

@BlackDex commented on GitHub (Jul 15, 2021):

Closing because PR #1848 has been merged

@BlackDex commented on GitHub (Jul 15, 2021): Closing because PR #1848 has been merged
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/vaultwarden#1072