5.5 KiB
Contributing
We are happy that you want to contribute to Pocket ID and help to make it better!
Before you start
Before starting to work on a new feature, please open an issue first, or comment on an existing one, to discuss the implementation details. This saves you time and avoids the disappointment of having a PR closed later because the change doesn't fit the project's direction.
AI Usage Policy
We have nothing against using AI tools to assist your development. But we've seen a growing number of pull requests that appear to be fully or largely AI-generated and submitted without genuine human review. These are difficult and time-consuming for maintainers to review, and they often waste everyone's time.
To keep contributions reviewable and high-quality, please follow these guidelines when using AI tools.
Guidelines for Using AI Tools
- Understand every line. You must be able to explain what your code does and why, in your own words. "The AI wrote it" is not an acceptable answer to a reviewer's question.
- Test before submitting. Review and test all code manually, as a human, before opening a PR. Don't trust the AI's claim that it works.
- Write your own words. Don't paste AI-generated text into issues, comments, or PR descriptions. Walls of generated text make discussions harder, not easier.
- Disclose your usage. Note in the PR description how you used AI (see below).
PRs that appear to be low effort AI output may be closed without a detailed review.
Example disclosure
Used GitHub Copilot for autocomplete, and asked an LLM to help draft the test cases in
parser_test.go. I reviewed, edited, and tested everything myself and understand how it works.
Used an LLM to generate the initial implementation of the new API endpoint, but I manually reviewed and tested it before submitting.
Getting started
Submit a Pull Request
Before you submit the pull request for review please ensure that
-
The pull request naming follows the Conventional Commits specification:
<type>[optional scope]: <description>example:
fix: hide global audit log switch for non admin usersWhere
TYPEcan be:- feat - is a new feature
- doc - documentation only changes
- fix - a bug fix
- refactor - code change that neither fixes a bug nor adds a feature
-
Your pull request has a detailed description
-
You run
pnpm formatto format the code
Development Environment
Pocket ID consists of a frontend and backend. In production the frontend gets statically served by the backend, but in development they run as separate processes to enable hot reloading.
There are two ways to get the development environment setup:
1. Install required tools
With Dev Containers
If you use Dev Containers in VS Code, you don't need to install anything manually, just follow the steps below.
- Make sure you have Dev Containers extension installed
- Clone and open the repo in VS Code
- VS Code will detect .devcontainer and will prompt you to open the folder in devcontainer
- If the auto prompt does not work, hit
F1and selectDev Containers: Open Folder in Container., then select the pocket-id repo root folder and it'll open in container.
Without Dev Containers
If you don't use Dev Containers, you need to install the following tools manually:
2. Setup
Backend
The backend is built with Gin and written in Go. To set it up, follow these steps:
- Open the
backendfolder - Copy the
.env.development-examplefile to.envand edit the variables as needed - Start the backend with
go run -tags exclude_frontend ./cmd
Frontend
The frontend is built with SvelteKit and written in TypeScript. To set it up, follow these steps:
- Open the
pocket-idproject folder - Copy the
frontend/.env.development-examplefile tofrontend/.envand edit the variables as needed - Install the dependencies with
pnpm install - Start the frontend with
pnpm dev
You're all set! The application is now listening on localhost:3000. The backend gets proxied trough the frontend in development mode.
Testing
If you are contributing to a new feature please ensure that you add tests for it.
End-to-end tests
We are using Playwright for end-to-end testing.
The tests are located in the tests folder at the root of the project.
The tests can be run like this:
-
Install the dependencies from the root of the project
pnpm install -
Visit the setup folder by running
cd tests/setup -
Start the test environment by running
docker compose up -d --build -
Go back to the test folder by running
cd .. -
Run the tests with
pnpm dlx playwright testor from the root project folderpnpm test
If you make any changes to the application, you have to rebuild the test environment by running docker compose up -d --build again.
Unit tests
In the backend we are using unit tests with the built-in Go testing framework. The tests are located in the same folder as the code they are testing and have the _test.go suffix.
To run the tests, simply run go test -tags=exclude_frontend,unit ./... from the root of the backend folder.